Skip to content

Commit d357bcd

Browse files
committed
fix some shellcheck failures in hack
1 parent 9dbc891 commit d357bcd

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

hack/.shellcheck_failures

-4
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,10 @@
3838
./cluster/update-storage-objects.sh
3939
./cluster/validate-cluster.sh
4040
./hack/cherry_pick_pull.sh
41-
./hack/generate-bindata.sh
42-
./hack/generate-docs.sh
4341
./hack/ginkgo-e2e.sh
4442
./hack/godep-restore.sh
4543
./hack/godep-save.sh
4644
./hack/grab-profiles.sh
47-
./hack/install-etcd.sh
4845
./hack/jenkins/benchmark-dockerized.sh
4946
./hack/jenkins/build.sh
5047
./hack/jenkins/test-dockerized.sh
@@ -76,7 +73,6 @@
7673
./hack/make-rules/vet.sh
7774
./hack/test-integration.sh
7875
./hack/test-update-storage-objects.sh
79-
./hack/update-bazel.sh
8076
./hack/update-codegen.sh
8177
./hack/update-generated-kms-dockerized.sh
8278
./hack/update-generated-protobuf-dockerized.sh

hack/generate-bindata.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ set -o errexit
1818
set -o pipefail
1919
set -o nounset
2020

21-
export KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
21+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
22+
export KUBE_ROOT
2223
source "${KUBE_ROOT}/hack/lib/init.sh"
2324
source "${KUBE_ROOT}/hack/lib/logging.sh"
2425

hack/generate-docs.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ set -o errexit
2222
set -o nounset
2323
set -o pipefail
2424

25-
KUBE_HACK_ROOT=$(dirname "${BASH_SOURCE}")
25+
KUBE_HACK_ROOT=$(dirname "${BASH_SOURCE[0]}")
2626

2727
echo "WARNING: hack/generate-docs.sh is an alias for hack/update-generated-docs.sh"
2828
echo "and will be removed in a future version."

hack/install-etcd.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ set -o errexit
2121
set -o nounset
2222
set -o pipefail
2323

24-
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
24+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2525
source "${KUBE_ROOT}/hack/lib/init.sh"
2626

2727
kube::etcd::install

hack/update-bazel.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ set -o errexit
1717
set -o nounset
1818
set -o pipefail
1919

20-
export KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
20+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
21+
export KUBE_ROOT
2122
source "${KUBE_ROOT}/hack/lib/init.sh"
2223

2324
# Ensure that we find the binaries we build before anything else.

0 commit comments

Comments
 (0)