[MODINVSTOR-1427] Fixed instance creation (folio-org#1208)

Author: damien-git

NEWS.md

@@ -21,6 +21,7 @@
 * Fix error serialization when writing to files uploaded to S3 ([MODINVSTOR-1389](https://folio-org.atlassian.net/browse/MODINVSTOR-1389))
 * Fix changes propagation to shadow instances after shared instance update ([MODINVSTOR-1393](https://folio-org.atlassian.net/browse/MODINVSTOR-1393))
 * Fix metadata not filled for records created via `POST /instance-storage/batch/synchronous`([MODINVSTOR-1382](https://folio-org.atlassian.net/browse/MODINVSTOR-1382))
+* Fixed random "`Cannot set holdings_record.instanceid = [...] because it does not exist in instance.id.`" errors when opening orders ([MODINVSTOR-1427](https://folio-org.atlassian.net/browse/MODINVSTOR-1427))
 
 ### Tech Dept
 * Description ([ISSUE](https://folio-org.atlassian.net/browse/ISSUE))

src/main/java/org/folio/services/instance/InstanceService.java

@@ -140,15 +140,15 @@ public Future<Response> createInstance(Instance entity) {
                 return Future.succeededFuture(respond400WithTextPlain(response.getEntity()));
               }
             })
-            .onSuccess(postResponse::complete)
-            .onFailure(throwable -> {
-              if (throwable instanceof PgException pgException) {
-                postResponse.complete(respond400WithTextPlain(pgException.getDetail()));
-              } else {
-                postResponse.complete(respond400WithTextPlain(throwable.getMessage()));
-              }
-            })
-        );
+        )
+          .onSuccess(postResponse::complete)
+          .onFailure(throwable -> {
+            if (throwable instanceof PgException pgException) {
+              postResponse.complete(respond400WithTextPlain(pgException.getDetail()));
+            } else {
+              postResponse.complete(respond400WithTextPlain(throwable.getMessage()));
+            }
+          });
 
         return postResponse.future()
             // Return the response without waiting for a domain event publish