Lint touched files and regenerate .rubocop_todo.yml

Author: skryukov

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 10000`
-# on 2025-03-01 10:06:34 UTC using RuboCop version 1.73.1.
+# on 2025-03-04 09:53:10 UTC using RuboCop version 1.73.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -15,20 +15,6 @@ Layout/ArgumentAlignment:
     - 'bin/console'
     - 'spec/inertia/response_spec.rb'
 
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Layout/BlockEndNewline:
-  Exclude:
-    - 'spec/inertia/rendering_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Layout/EmptyLineAfterGuardClause:
@@ -49,14 +35,6 @@ Layout/EmptyLinesAroundBlockBody:
   Exclude:
     - 'spec/inertia/rails_mimic_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
@@ -76,16 +54,11 @@ Layout/FirstArgumentIndentation:
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: IndentationWidth.
+# Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
 Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Layout/MultilineBlockLayout:
   Exclude:
-    - 'spec/inertia/rendering_spec.rb'
+    - 'spec/inertia/rspec_helper_spec.rb'
 
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
@@ -116,18 +89,17 @@ Layout/SpaceInsideArrayLiteralBrackets:
     - 'spec/dummy/app/controllers/inertia_test_controller.rb'
     - 'spec/dummy/config/environments/production.rb'
 
-# Offense count: 13
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceInsideBlockBraces:
   Exclude:
     - 'spec/inertia/error_sharing_spec.rb'
-    - 'spec/inertia/rendering_spec.rb'
     - 'spec/inertia/request_spec.rb'
 
-# Offense count: 122
+# Offense count: 106
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -141,7 +113,6 @@ Layout/SpaceInsideHashLiteralBraces:
     - 'spec/inertia/conditional_sharing_spec.rb'
     - 'spec/inertia/middleware_spec.rb'
     - 'spec/inertia/rails_mimic_spec.rb'
-    - 'spec/inertia/rendering_spec.rb'
     - 'spec/inertia/request_spec.rb'
     - 'spec/inertia/rspec_helper_spec.rb'
     - 'spec/inertia/sharing_spec.rb'
@@ -193,12 +164,6 @@ Lint/SymbolConversion:
   Exclude:
     - 'spec/inertia/rails_mimic_spec.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowKeywordBlockArguments.
-Lint/UnderscorePrefixedVariableName:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
@@ -230,7 +195,7 @@ Naming/VariableNumber:
   Exclude:
     - 'spec/dummy/app/controllers/inertia_test_controller.rb'
 
-# Offense count: 25
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
@@ -242,7 +207,7 @@ Style/BlockDelimiters:
     - 'lib/inertia_rails/controller.rb'
     - 'spec/inertia/action_filter_spec.rb'
     - 'spec/inertia/conditional_sharing_spec.rb'
-    - 'spec/inertia/rendering_spec.rb'
+    - 'spec/inertia/rails_mimic_spec.rb'
     - 'spec/inertia/request_spec.rb'
     - 'spec/inertia/rspec_helper_spec.rb'
     - 'spec/inertia/sharing_spec.rb'
@@ -255,26 +220,11 @@ Style/ClassAndModuleChildren:
   Exclude:
     - 'lib/inertia_rails/helper.rb'
 
-# Offense count: 2
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Style/ColonMethodCall:
   Exclude:
     - 'spec/inertia/error_sharing_spec.rb'
-    - 'spec/inertia/rendering_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/EachWithObject:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -305,7 +255,7 @@ Style/ExpandPathArguments:
   Exclude:
     - 'spec/rails_helper.rb'
 
-# Offense count: 71
+# Offense count: 69
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -314,7 +264,6 @@ Style/FrozenStringLiteralComment:
     - '**/*.arb'
     - 'app/controllers/inertia_rails/static_controller.rb'
     - 'bin/console'
-    - 'lib/inertia_rails.rb'
     - 'lib/inertia_rails/controller.rb'
     - 'lib/inertia_rails/engine.rb'
     - 'lib/inertia_rails/helper.rb'
@@ -374,7 +323,6 @@ Style/FrozenStringLiteralComment:
     - 'spec/inertia/lazy_prop_spec.rb'
     - 'spec/inertia/middleware_spec.rb'
     - 'spec/inertia/rails_mimic_spec.rb'
-    - 'spec/inertia/rendering_spec.rb'
     - 'spec/inertia/request_spec.rb'
     - 'spec/inertia/response_spec.rb'
     - 'spec/inertia/rspec_helper_spec.rb'
@@ -445,12 +393,6 @@ Style/MutableConstant:
   Exclude:
     - 'lib/inertia_rails/version.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Style/NegatedIfElseCondition:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Style/NestedModifier:
@@ -490,12 +432,6 @@ Style/RedundantReturn:
   Exclude:
     - 'spec/dummy/app/controllers/inertia_session_continuity_test_controller.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RescueModifier:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowIfMethodIsEmpty.
@@ -510,7 +446,7 @@ Style/SoleNestedConditional:
   Exclude:
     - 'lib/inertia_rails/controller.rb'
 
-# Offense count: 82
+# Offense count: 78
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
@@ -521,7 +457,6 @@ Style/StringLiterals:
     - 'lib/inertia_rails/engine.rb'
     - 'lib/inertia_rails/helper.rb'
     - 'lib/inertia_rails/middleware.rb'
-    - 'lib/inertia_rails/renderer.rb'
     - 'lib/inertia_rails/rspec.rb'
     - 'lib/inertia_rails/version.rb'
     - 'lib/patches/better_errors.rb'
@@ -543,14 +478,6 @@ Style/StringLiterals:
     - 'spec/rails_helper.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
-  Exclude:
-    - 'lib/inertia_rails/renderer.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: .
@@ -559,16 +486,14 @@ Style/SymbolArray:
   EnforcedStyle: percent
   MinSize: 3
 
-# Offense count: 14
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInArguments:
   Exclude:
-    - 'lib/inertia_rails.rb'
     - 'spec/dummy/app/controllers/inertia_config_test_controller.rb'
     - 'spec/dummy/app/controllers/inertia_rails_mimic_controller.rb'
-    - 'spec/inertia/rendering_spec.rb'
 
 # Offense count: 22
 # This cop supports safe autocorrection (--autocorrect).
@@ -586,16 +511,15 @@ Style/TrailingCommaInHashLiteral:
     - 'spec/inertia/response_spec.rb'
     - 'spec/inertia/rspec_helper_spec.rb'
 
-# Offense count: 2
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   Exclude:
     - 'lib/inertia_rails/middleware.rb'
-    - 'spec/inertia/rendering_spec.rb'
 
-# Offense count: 26
+# Offense count: 17
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https

lib/inertia_rails.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'inertia_rails/renderer'
 require 'inertia_rails/engine'
 
@@ -17,7 +19,7 @@
     view_data: options[:view_data],
     deep_merge: options[:deep_merge],
     encrypt_history: options[:encrypt_history],
-    clear_history: options[:clear_history],
+    clear_history: options[:clear_history]
   ).render
 end
 

lib/inertia_rails/renderer.rb

@@ -19,8 +19,12 @@ class Renderer
       :clear_history
     )
 
-    def initialize(component, controller, request, response, render_method, props: nil, view_data: nil, deep_merge: nil, encrypt_history: nil, clear_history: nil)
-      raise ArgumentError, 'Parameter `props` is not allowed when passing a Hash as the first argument' if component.is_a?(Hash) && !props.nil?
+    def initialize(component, controller, request, response, render_method, props: nil, view_data: nil,
+                   deep_merge: nil, encrypt_history: nil, clear_history: nil)
+      if component.is_a?(Hash) && !props.nil?
+        raise ArgumentError,
+              'Parameter `props` is not allowed when passing a Hash as the first argument'
+      end
 
       @controller = controller
       @configuration = controller.__send__(:inertia_configuration)
@@ -30,22 +34,26 @@ def initialize(component, controller, request, response, render_method, props: n
       @render_method = render_method
       @props = props || (component.is_a?(Hash) ? component : controller.__send__(:inertia_view_assigns))
       @view_data = view_data || {}
-      @deep_merge = !deep_merge.nil? ? deep_merge : configuration.deep_merge_shared_data
-      @encrypt_history = !encrypt_history.nil? ? encrypt_history : configuration.encrypt_history
+      @deep_merge = deep_merge.nil? ? configuration.deep_merge_shared_data : deep_merge
+      @encrypt_history = encrypt_history.nil? ? configuration.encrypt_history : encrypt_history
       @clear_history = clear_history || controller.session[:inertia_clear_history] || false
     end
 
     def render
-      if @response.headers["Vary"].blank?
-        @response.headers["Vary"] = 'X-Inertia'
-      else
-        @response.headers["Vary"] = "#{@response.headers["Vary"]}, X-Inertia"
-      end
+      @response.headers['Vary'] = if @response.headers['Vary'].blank?
+                                    'X-Inertia'
+                                  else
+                                    "#{@response.headers['Vary']}, X-Inertia"
+                                  end
       if @request.headers['X-Inertia']
         @response.set_header('X-Inertia', 'true')
         @render_method.call json: page.to_json, status: @response.status, content_type: Mime[:json]
       else
-        return render_ssr if configuration.ssr_enabled rescue nil
+        begin
+          return render_ssr if configuration.ssr_enabled
+        rescue StandardError
+          nil
+        end
         @render_method.call template: 'inertia', layout: layout, locals: view_data.merge(page: page)
       end
     end
@@ -56,7 +64,7 @@ def render_ssr
       uri = URI("#{configuration.ssr_url}/render")
       res = JSON.parse(Net::HTTP.post(uri, page.to_json, 'Content-Type' => 'application/json').body)
 
-      controller.instance_variable_set("@_inertia_ssr_head", res['head'].join.html_safe)
+      controller.instance_variable_set('@_inertia_ssr_head', res['head'].join.html_safe)
       @render_method.call html: res['body'].html_safe, layout: layout, locals: view_data.merge(page: page)
     end
 
@@ -83,19 +91,19 @@ def merge_props(shared_data, props)
     end
 
     def computed_props
-      _props = merge_props(shared_data, props)
+      merged_props = merge_props(shared_data, props)
 
-      deep_transform_props _props do |prop, path|
+      deep_transform_props merged_props do |prop, path|
         next [DONT_KEEP_PROP] unless keep_prop?(prop, path)
 
         transformed_prop = case prop
-        when BaseProp
-          prop.call(controller)
-        when Proc
-          controller.instance_exec(&prop)
-        else
-          prop
-        end
+                           when BaseProp
+                             prop.call(controller)
+                           when Proc
+                             controller.instance_exec(&prop)
+                           else
+                             prop
+                           end
 
         [KEEP_PROP, transformed_prop]
       end
@@ -121,7 +129,7 @@ def page
     end
 
     def deep_transform_props(props, parent_path = [], &block)
-      props.reduce({}) do |transformed_props, (key, prop)|
+      props.each_with_object({}) do |(key, prop), transformed_props|
         current_path = parent_path + [key]
 
         if prop.is_a?(Hash) && prop.any?
@@ -131,8 +139,6 @@ def deep_transform_props(props, parent_path = [], &block)
           action, transformed_prop = block.call(prop, current_path)
           transformed_props.merge!(key => transformed_prop) if action == KEEP_PROP
         end
-
-        transformed_props
       end
     end