-
Notifications
You must be signed in to change notification settings - Fork 69
Description
I'm encountering a few issues while setting up the @inertiaui/modal-react
library with Inertia-Rails. Here's a breakdown:
1. CSS Import Not Applying Styles
This line is included in the guide, but it doesn't seem to actually apply any styles, nor do I see any CSS files inside of the node_modules
.
@source "../../../node_modules/@inertiaui/modal-react";
2. Conflicting Instructions for Inertia Configuration
In this section of the docs:
https://inertia-rails.dev/cookbook/inertia-modal#_2-configure-inertia
It says to replace createElement with renderApp in the inertia.ts setup. However, createElement is still used in another part of the template here:
https://github.com/skryukov/inertia-rails-shadcn-starter/blob/2316c6fa5d9f69d695fd9ed33de6ff885e78d1d9/app/frontend/entrypoints/inertia.ts#L35
It's not clear how this should be fixed or reconciled.
3. Missing Information on TypeScript Support
There's also no mention that this package doesn't support types. It would be great to include guidance on how to handle this (e.g., any workarounds or plans for adding type definitions).
Thanks for your help! Let me know if you need more details.