Skip to content
This repository has been archived by the owner on Sep 28, 2018. It is now read-only.

Remove require of encoding-indexes.js #44

Open
arv opened this issue Nov 17, 2015 · 4 comments
Open

Remove require of encoding-indexes.js #44

arv opened this issue Nov 17, 2015 · 4 comments

Comments

@arv
Copy link

arv commented Nov 17, 2015

Right now encoding-indexes.js is always required in a node like environment (such as browserify).

This was done in a85ce6f

It would be better if encoding-indexes.js was never implicitly included.

@inexorabletash
Copy link
Owner

Suggestions (or PRs) appreciated. I want to keep things testable out of the box (i.e. runnable via gh-pages) but otherwise I'm amenable to pretty much anything.

@cgwyllie
Copy link

Something with this that would allow selective inclusion of different encodings would be good for us. We are only interested in UTF-8 and build using webpack, but we end up with all encodings getting bundled.

Not sure what the best option might be..

@inexorabletash
Copy link
Owner

Again, happy to do this but I am unfamiliar with these environments and so guidance is needed.

@surfjedi
Copy link

Yes I am experiencing the same thing - using web pack to build and don't want indexes.. great polyfill tho

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants