Skip to content

Commit acb3f7c

Browse files
committed
Resolve test failures from MPI and ecc removal
Scale inputs in prepare_inputs_for_verification so verify receives integer field values instead of raw floats. Remove stale ecc assertions from dispatch test and OMPI MCA expectations from env test.
1 parent 6f56e1b commit acb3f7c

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

python/core/circuits/base.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,10 +335,9 @@ def prepare_inputs_for_verification(
335335
Returns:
336336
str: name of file with processed inputs for verification
337337
"""
338-
# read inputs
339338
inputs = self._read_from_json_safely(exec_config.input_file)
340-
# reshape inputs for circuit reading (or for verification check in this case)
341-
processed_inputs = self.reshape_inputs_for_circuit(inputs)
339+
scaled_inputs = self.scale_inputs_only(inputs)
340+
processed_inputs = self.reshape_inputs_for_circuit(scaled_inputs)
342341
# Send back to file
343342
path = Path(exec_config.input_file)
344343
processed_input_file = str(path.parent / (path.stem + "_veri" + path.suffix))

python/tests/circuit_parent_classes/test_circuit.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ def test_parse_proof_dispatch_logic(
267267
"proof_file": "p",
268268
"proof_system": ZKProofSystems.Expander,
269269
"dev_mode": False,
270-
"ecc": True,
271270
"bench": False,
272271
"metadata_path": "metadata",
273272
"compress": True,
@@ -305,7 +304,6 @@ def test_parse_proof_dispatch_logic(
305304
"proof_file": "p",
306305
"proof_system": ZKProofSystems.Expander,
307306
"dev_mode": False,
308-
"ecc": True,
309307
"bench": False,
310308
"metadata_path": "metadata",
311309
}

python/tests/utils_testing/test_helper_functions.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,3 @@ def test_prepare_subprocess_env_sets_mca_defaults() -> None:
997997
env = {"PATH": "/usr/bin"}
998998
result = _prepare_subprocess_env(env)
999999
assert result is env
1000-
assert result["OMPI_MCA_mca_base_component_show_load_errors"] == "0"
1001-
assert result["PRTE_MCA_prte_silence_shared_fs"] == "1"
1002-
assert "LD_LIBRARY_PATH" not in result
1003-
assert "DYLD_LIBRARY_PATH" not in result

0 commit comments

Comments
 (0)