[#2492] Proper version comparison when deciding whether to use compare api

Author: Crumby

controllers/cache_controller.go

@@ -669,7 +669,8 @@ func configChanged(a, b string, i *v1.Infinispan, caches api.Caches, vm *version
 	// If Operand is >= 14.0.7.Final we can use the cache compare endpoint to avoid unnecessary updates to the
 	// Infinispan spec.template field
 	operand, _ := vm.WithRef(i.Spec.Version)
-	if operand.UpstreamVersion.Major >= 14 && operand.UpstreamVersion.Patch >= 7 {
+
+	if operand.UpstreamVersion.GE(constants.MinVersionCacheCompareEndpoint) {
 		// Check if Cache configuration is semantically the same as that already present in the Cache CR
 		equalConfig, err := caches.EqualConfiguration(a, b)
 		if err != nil {

controllers/constants/constants.go

@@ -57,6 +57,13 @@ var (
 		Minor: 0,
 		Patch: 7,
 	}
+
+	// 14.0.7.Final is required for ?action=compare endpoint
+	MinVersionCacheCompareEndpoint = semver.Version{
+		Major: 14,
+		Minor: 0,
+		Patch: 7,
+	}
 )
 
 const (