[#148] Fix CQ proto syntax ordering and event buffering

Move 'syntax = "proto3"' before 'package' declaration — Protostream
requires the syntax statement to be the first non-comment line.

Buffer CQ state events during listener registration so that includeState
events are not lost before the caller attaches .on() handlers. Also
propagate errors from addContinuousQuery instead of swallowing them.

Author: tristantarrant

lib/listeners.js

@@ -186,6 +186,9 @@
           return f.cat(encodeListenerAddCommon, encodeListenerAddInterests);
         };
 
+        var bufferedEvents = [];
+        var buffering = true;
+
         var cqEmitFn = function(event, emitter, bytebuf) {
           var payloadLength = codec.decodeVariableBytes()(bytebuf);
           if (!f.existy(payloadLength) || !f.existy(payloadLength.answer))
@@ -195,7 +198,11 @@
           if (!f.existy(wrapped) || !f.existy(wrapped.wrappedMessage))
             return true;
           var cqResult = codec.decodeContinuousQueryResult(wrapped.wrappedMessage);
-          emitter.emit(cqResult.resultType, cqResult.key, cqResult.value, cqResult.projection);
+          if (buffering) {
+            bufferedEvents.push(cqResult);
+          } else {
+            emitter.emit(cqResult.resultType, cqResult.key, cqResult.value, cqResult.projection);
+          }
           return true;
         };
 
@@ -219,15 +226,26 @@
               var l = listeners.get(listenerId);
               var emitter = l.emitter;
               return {
-                on: function(event, callback) { emitter.on(event, callback); return this; },
+                on: function(event, callback) {
+                  emitter.on(event, callback);
+                  if (buffering) {
+                    buffering = false;
+                    bufferedEvents.forEach(function(ev) {
+                      emitter.emit(ev.resultType, ev.key, ev.value, ev.projection);
+                    });
+                    bufferedEvents = [];
+                  }
+                  return this;
+                },
                 getListenerId: function() { return listenerId; }
               };
             }
             listen.removeListeners(listenerId);
             return undefined;
           })
-          .catch(function() {
+          .catch(function(err) {
             listen.removeListeners(listenerId);
+            throw err;
           });
       },
     };

spec/infinispan_cq_spec.js

@@ -4,8 +4,8 @@ var t = require('./utils/testing');
 var ispn = require('../lib/infinispan');
 var protobuf = require('protobufjs');
 
-var personProto = 'package tutorial;\n'
-  + 'syntax = "proto3";\n'
+var personProto = 'syntax = "proto3";\n'
+  + 'package tutorial;\n'
   + '/**\n'
   + ' * @TypeId(1000042)\n'
   + ' */\n'