HashMaps

[jonsalvas]

I am just curious: Is there a particular reason why CommonContainerTypes do not provide a HashMapAdapter (which at least maps to a list of objects with key/value)? Or why protostream lacks of Map Support in general? According to Protobuf HashMap are even now natively supported https://protobuf.dev/programming-guides/proto3/#maps.

[tristantarrant]

Maps are supported natively since 5.0 without the need for adapters

[jonsalvas]

is that so? :O Thanks for the hint ! I am using it in context of quarkus 3.19.1 I would expect it to be included and during compile time I get

org.infinispan.protostream.annotations.ProtoSchemaBuilderException: Found a reference to class java.util.HashMap which was not explicitly included by @AutoProtoSchemaBuilder and the combination of relevant attributes (basePackages, includeClasses, excludeClasses, autoImportClasses) do not allow it to be included.

[tristantarrant]

You must also use

@ProtoSchema(syntax=ProtoSyntax.PROTO3)

[jonsalvas]

same error unfortunately :(

[tristantarrant]

Ah, if your field is actually of type HashMap then we do need a container type. If you can, just convert it to Map

[jonsalvas]

Interestingly I converted it to HashMap because it complained about abstract types. If I change it back to Map, in fact:

org.infinispan.protostream.annotations.ProtoSchemaBuilderException: IPROTO000014: The type java.util.Map of field templateData of <somepackage>.Regel should not be abstract.

[jonsalvas]

maybe I have to be more precise with my requirement. I have a field like that:

protected ArrayList<HashMap<String, Object>> templateData;

[tristantarrant]

I have created #514

[jonsalvas]

I implemented a custom Map Adapter for now which is working fine. However my biggest challenge right now is marshalling/unmarshalling the java.lang.Object type which, in my implementation, takes 50% of all cpu time. It would be great to be able to let protostream marshall it into the any type https://protobuf.dev/programming-guides/proto3/#any to have it as efficient as possible