Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - PHP 8.4 fixes #450

Open
dingo-d opened this issue Feb 19, 2025 · 0 comments
Open

[FEATURE] - PHP 8.4 fixes #450

dingo-d opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
feature request New feature request

Comments

@dingo-d
Copy link
Contributor

dingo-d commented Feb 19, 2025

I noticed I got several deprecation notices while running some WPCLI scripts, for instance:

PHP Deprecated: EightshiftLibs\Cache\AbstractManifestCache::getCacheTopItem(): Implicitly marking parameter $fallback as nullable is deprecated, the explicit nullable type must be used instead
PHP Deprecated: EightshiftLibs\Helpers\ShortcodeTrait::getShortcode(): Implicitly marking parameter $content as nullable is deprecated, the explicit nullable type must be used instead
PHP Deprecated: EightshiftLibs\Main\Autowiring::setManifestCache(): Implicitly marking parameter $manifestCache as nullable is deprecated, the explicit nullable type must be used instead

You should run the automated tools to check for these and make a bc compatible fix.

@dingo-d dingo-d added the feature request New feature request label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants