Merge pull request #3 from informalsystems/dangush/poolrseed

refactor: Rseed as Fq

Author: dangush

.github/workflows/buf-pull-request.yml

@@ -48,7 +48,7 @@ jobs:
   # Run our bespoke tooling for codegen, consuming the protocol buffer definitions
   # and emitting generated code. Afterward, there should be no uncommitted changes.
   build:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout the source code
         uses: actions/checkout@v4

.github/workflows/containers.yml

@@ -12,7 +12,7 @@ on:
   workflow_dispatch:
 jobs:
   penumbra:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     permissions:
       contents: read
       packages: write

.github/workflows/crates.yml

@@ -14,7 +14,7 @@ on:
 
 jobs:
   publish:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     env:
       CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
     steps:

.github/workflows/docs-lint.yml

@@ -10,7 +10,7 @@ jobs:
     # We use a custom script to generate the index page for https://rustdoc.penumbra.zone,
     # and refactors to rust deps can break that generation. Let's ensure this script exits 0
     # on PRs, but we'll still only deploy after merge into main.
-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -38,7 +38,7 @@ jobs:
   # In particular, links are checked within the docs.
   mdbook:
     # Downgrading runner size to 4vcpu, since we're not compiling code.
-    runs-on: buildjet-4vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/notes.yml

@@ -13,7 +13,7 @@ jobs:
   # and only runs post-merge on main, so 10m isn't bad.
   build:
     timeout-minutes: 30
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout the source code
         uses: actions/checkout@v4

.github/workflows/rust.yml

@@ -14,7 +14,7 @@ concurrency:
 
 jobs:
   lint:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -58,7 +58,7 @@ jobs:
   # As of 2025Q1, the "features" job is the slowest in the CI suite.
   # Consider moving to a scheduled job on main, rather than running on PRs.
   features:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -86,7 +86,7 @@ jobs:
         run: nix develop --command ./deployments/scripts/check-wasm-compat.sh
 
   test:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/smoke.yml

@@ -14,7 +14,7 @@ concurrency:
 
 jobs:
   smoke:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -40,7 +40,7 @@ jobs:
         run: nix develop --command just smoke
 
   pmonitor:
-    runs-on: buildjet-16vcpu-ubuntu-2204
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -66,7 +66,7 @@ jobs:
   # Temporarily disabling these in CI, as the testnet endpoints are
   # incompatible with `main`, given GH5010.
   # testnet:
-  #   runs-on: buildjet-16vcpu-ubuntu-2204
+  #   runs-on: ubuntu-latest
   #   steps:
   #     - uses: actions/checkout@v4
   #       with:

crates/bench/benches/nullifier_derivation.rs

@@ -38,7 +38,7 @@ fn nullifier_derivation_proving_time(c: &mut Criterion) {
     let note = Note::from_parts(
         address,
         Value::from_str("1upenumbra").expect("valid value"),
-        Rseed([1u8; 32]),
+        Rseed::from([1u8; 32]),
     )
     .expect("can make a note");
     let nullifier = Nullifier(Fq::from(1u64));

crates/bench/benches/output.rs

@@ -35,7 +35,8 @@ fn output_proving_time(c: &mut Criterion) {
     .expect("generated 1 address");
     let value_to_send = Value::from_str("1upenumbra").expect("valid value");
 
-    let note = Note::from_parts(address, value_to_send, Rseed([1u8; 32])).expect("can make a note");
+    let note =
+        Note::from_parts(address, value_to_send, Rseed::from([1u8; 32])).expect("can make a note");
     let balance_blinding = Fr::from(1u32);
     let balance_commitment = (-Balance::from(value_to_send)).commit(balance_blinding);
     let note_commitment = note.commit();

crates/core/component/dex/src/swap/plaintext.rs

@@ -57,8 +57,8 @@ impl SwapPlaintext {
         let rseed_1_hash = hash_1(&OUTPUT_1_BLINDING_DOMAIN_SEPARATOR, fq_rseed);
         let rseed_2_hash = hash_1(&OUTPUT_2_BLINDING_DOMAIN_SEPARATOR, fq_rseed);
         (
-            Rseed(rseed_1_hash.to_bytes()),
-            Rseed(rseed_2_hash.to_bytes()),
+            Rseed::from(rseed_1_hash.to_bytes()),
+            Rseed::from(rseed_2_hash.to_bytes()),
         )
     }
 
@@ -317,7 +317,7 @@ impl TryFrom<pb::SwapPlaintext> for SwapPlaintext {
                 .trading_pair
                 .ok_or_else(|| anyhow::anyhow!("missing trading pair in SwapPlaintext"))?
                 .try_into()?,
-            rseed: Rseed(plaintext.rseed.as_slice().try_into()?),
+            rseed: Rseed::from(plaintext.rseed.as_slice()),
         })
     }
 }
@@ -401,7 +401,7 @@ impl TryFrom<&[u8]> for SwapPlaintext {
                 asset_id: asset::Id::try_from(fee_asset_id_bytes)?,
             }),
             claim_address: pb_address.try_into()?,
-            rseed: Rseed(rseed),
+            rseed: Rseed::from(rseed),
         })
     }
 }