Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SlotMixin Test with wrong assumption about polyfill being loaded #2358

Open
aghArdeshir opened this issue Aug 30, 2024 · 0 comments
Open

Comments

@aghArdeshir
Copy link
Contributor

aghArdeshir commented Aug 30, 2024

Expected behavior

There is a test with title: does not scope elements when polyfill not loaded in context of SlotMixin - Scoped Registries, and there is a polyfill being loaded in the web-test-runner.config.mjs:

    <script src="/node_modules/@webcomponents/scoped-custom-element-registry/scoped-custom-element-registry.min.js"></script>

So I believe this test is having wrong assumption.

Actual Behavior

I created this draft PR as a prof: #2357
This PR:

  • Removes every other test in the SlotMixin test file
  • Removes the polyfill from web-test-runner.config
  • Filters only the tests in the core folder so we see the proof faster

This test fails when polyfill is not loaded, but passes as soon as you add back the polyfill in the web-test-runner.config file.

Additional context

I really don't understand the context of these scoped elements really that much, so these changes are kinda done blindly, based on the obvious facts I observed (title of the test for instance)

I faced this blocker when trying to run every test with both polyfill loaded and without polyfill loaded for this PR: #2353

What I want to ideally achieve is to be able to get rid of this test. Remove it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant