fix(audit): instrinsic gas (#170)

* fix: apply intrinsic gas and include caller in access lists

* fix: gas charging logic

* chore(fix): add missed keeper

x/evm/keeper/context.go

@@ -13,11 +13,13 @@ import (
 
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/common/hexutil"
+	"github.com/ethereum/go-ethereum/core"
 	"github.com/ethereum/go-ethereum/core/state"
 	"github.com/ethereum/go-ethereum/core/tracing"
 	coretype "github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/core/vm"
 	"github.com/ethereum/go-ethereum/crypto"
+	"github.com/ethereum/go-ethereum/params"
 	"github.com/ethereum/go-ethereum/trie/utils"
 
 	evmstate "github.com/initia-labs/minievm/x/evm/state"
@@ -32,6 +34,17 @@ func (k Keeper) NewStateDB(ctx context.Context, evm *vm.EVM, fee types.Fee) (*ev
 	)
 }
 
+func (k Keeper) chargeIntrinsicGas(gasBalance uint64, isContractCreation bool, data []byte, list coretype.AccessList, rules params.Rules) (uint64, error) {
+	intrinsicGas, err := core.IntrinsicGas(data, list, isContractCreation, rules.IsHomestead, rules.IsIstanbul, rules.IsShanghai)
+	if err != nil {
+		return 0, err
+	}
+	if gasBalance < intrinsicGas {
+		return 0, fmt.Errorf("%w: have %d, want %d", core.ErrIntrinsicGas, gasBalance, intrinsicGas)
+	}
+	return gasBalance - intrinsicGas, nil
+}
+
 func (k Keeper) computeGasLimit(sdkCtx sdk.Context) uint64 {
 	gasLimit := sdkCtx.GasMeter().Limit() - sdkCtx.GasMeter().GasConsumedToLimit()
 	if sdkCtx.ExecMode() == sdk.ExecModeSimulate {
@@ -249,13 +262,21 @@ func (k Keeper) EVMStaticCallWithTracer(ctx context.Context, caller common.Addre
 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	gasBalance := k.computeGasLimit(sdkCtx)
 	rules := evm.ChainConfig().Rules(evm.Context.BlockNumber, evm.Context.Random != nil, evm.Context.Time)
+	gasRemaining, err := k.chargeIntrinsicGas(gasBalance, false, inputBz, accessList, rules)
+	if err != nil {
+		return nil, err
+	}
+
+	if rules.IsEIP4762 {
+		evm.AccessEvents.AddTxOrigin(caller)
+	}
 	evm.StateDB.Prepare(rules, caller, types.NullAddress, &contractAddr, k.precompileAddrs(rules), accessList)
 
 	retBz, gasRemaining, err := evm.StaticCall(
 		vm.AccountRef(caller),
 		contractAddr,
 		inputBz,
-		gasBalance,
+		gasRemaining,
 	)
 
 	// London enforced
@@ -287,13 +308,23 @@ func (k Keeper) EVMCallWithTracer(ctx context.Context, caller common.Address, co
 	}
 
 	rules := evm.ChainConfig().Rules(evm.Context.BlockNumber, evm.Context.Random != nil, evm.Context.Time)
+	gasRemaining, err := k.chargeIntrinsicGas(gasBalance, false, inputBz, accessList, rules)
+	if err != nil {
+		return nil, nil, err
+	}
+
+	if rules.IsEIP4762 {
+		evm.AccessEvents.AddTxOrigin(caller)
+		evm.AccessEvents.AddTxDestination(contractAddr, value.Sign() != 0)
+	}
+
 	evm.StateDB.Prepare(rules, caller, types.NullAddress, &contractAddr, k.precompileAddrs(rules), accessList)
 
 	retBz, gasRemaining, err := evm.Call(
 		vm.AccountRef(caller),
 		contractAddr,
 		inputBz,
-		gasBalance,
+		gasRemaining,
 		value,
 	)
 
@@ -381,21 +412,29 @@ func (k Keeper) EVMCreateWithTracer(ctx context.Context, caller common.Address,
 	}
 
 	rules := evm.ChainConfig().Rules(evm.Context.BlockNumber, evm.Context.Random != nil, evm.Context.Time)
-	evm.StateDB.Prepare(rules, caller, types.NullAddress, nil, k.precompileAddrs(rules), accessList)
 
-	var gasRemaining uint64
+	gasRemaining, err := k.chargeIntrinsicGas(gasBalance, true, codeBz, accessList, rules)
+	if err != nil {
+		return nil, common.Address{}, nil, err
+	}
+
+	if rules.IsEIP4762 {
+		evm.AccessEvents.AddTxOrigin(caller)
+	}
+
+	evm.StateDB.Prepare(rules, caller, types.NullAddress, nil, k.precompileAddrs(rules), accessList)
 	if salt == nil {
 		retBz, contractAddr, gasRemaining, err = evm.Create(
 			vm.AccountRef(caller),
 			codeBz,
-			gasBalance,
+			gasRemaining,
 			value,
 		)
 	} else {
 		retBz, contractAddr, gasRemaining, err = evm.Create2(
 			vm.AccountRef(caller),
 			codeBz,
-			gasBalance,
+			gasRemaining,
 			value,
 			uint256.NewInt(*salt),
 		)