feat: upgrade + audit fixes

[beer-1]

Description

This PR includes dependency upgrades and also includes audit fixes.
need to wait: initia-labs/initia#349

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:

• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Integrated new API endpoints for enhanced auction and mempool functionality.
  • Added new parameters for gas price configurations.
  • Introduced new methods for recursive transaction handling in the Counter contract.
  • Enhanced gas limit management in various contract methods.

• Improvements

  • Enhanced error reporting and migration processes for smoother transaction execution.
  • Introduced validation for maximum address count in filter settings.
  • Improved management of execute requests within the Snapshot struct.
  • Streamlined error handling in precompile methods.

• Documentation

  • Expanded API documentation with revised JSON structures for mempool and auction interfaces.

• Chores

  • Upgraded dependencies and build scripts to boost system stability and performance.

[coderabbitai]

Walkthrough

This pull request integrates new functionality and improvements across multiple components of the blockchain application. It adds Block SDK integration into the mempool API and transaction service, updates genesis parameters, and refines API documentation with new auction and mempool endpoints. The upgrade process now runs migrations via the ModuleManager, and dependency versions are updated along with a new replacement directive. Additional changes include refactoring contract bytecodes and JSON formatting in oracle and ERC20 contracts, improving error handling in EVM context functions, and renaming fields in precompile structures.

Changes

File(s)	Change Summary
app/app.go	Integrated new Block SDK functionality: added mempool API routes and transaction service registration with a type assertion and error handling.
app/genesis.go	Added a new genesis parameter HookMaxGas with a value of 3,000,000 in the ConfigureMinGasPrices function.
app/ibc-hooks/README.md	Modified the ICS20 packet memo field format from a nested JSON object to a string representation.
app/keepers/keepers.go	Removed the communityPoolKeeper and packetforwardkeeper.DefaultRefundTransferPacketTimeoutTimestamp parameters from the NewAppKeeper function signature.
app/upgrade.go	Updated the upgrade version from "0.7.1" to "0.7.3" and changed the upgrade handler to use ModuleManager.RunMigrations for handling migrations.
client/docs/config.json client/docs/swagger-ui/swagger.yaml	Added new API documentation entries and endpoints for auction and mempool modules, including updated response schemas and definitions.
go.mod	Updated multiple dependency versions and added a replace directive for github.com/cosmos/iavl.
scripts/protoc-swagger-gen.sh	Added new variables (BLOCK_SDK_URL, BLOCK_SDK_V, etc.) and logic to clone the block-sdk repository and include its proto files.
x/evm/contracts/connect_oracle/ConnectOracle.go x/evm/contracts/connect_oracle/ConnectOracle.sol	Updated the contract bytecode (Bin field) and refactored JSON request construction by replacing a join method with a new marshal_string_array function.
x/evm/contracts/erc20_wrapper/ERC20Wrapper.go x/evm/contracts/erc20_wrapper/ERC20Wrapper.sol	Updated the ERC20 wrapper contract's binary representation and streamlined the construction of IBC transfer messages using JSON serialization.
x/evm/keeper/context.go	Reduced the maximum recursive depth (from 16 to 8) and improved error handling in EVM calls, including more granular panic propagation.
x/evm/keeper/keeper.go	Removed the atomic execIndex variable previously used for concurrency-safe tracking.
x/evm/keeper/precompiles.go	Expanded the precompile address list by adding JSONUtilsPrecompileAddress.
x/evm/precompiles/cosmos/contract.go x/evm/precompiles/cosmos/types.go	Renamed the Address field to Account in cosmos precompile argument structures and type definitions.
api/minievm/evm/v1/tx.pulsar.go	Updated the raw descriptor byte array for MsigCreate message, reflecting changes in the protobuf message structure.
proto/minievm/evm/v1/tx.proto	Added an Amino encoding option for the MsgUpdateParams message.
jsonrpc/namespaces/eth/filters/api.go	Introduced new error variable errExceedMaxAddrs and constant maxAddresses to limit filter addresses.
jsonrpc/namespaces/eth/filters/subscriptions.go	Added validation for address count in the Logs method, returning errExceedMaxAddrs if exceeded.
x/evm/contracts/counter/Counter.go x/evm/contracts/counter/Counter.sol	Added new functions recursive_revert and nested_recursive_revert to the Counter contract, including transaction bindings and event emissions.
x/evm/keeper/context_test.go	Added a new test function Test_Recursive_Audit_ExecuteRequestsNotCleanedOnRevert to validate contract behavior during specific conditions.
x/evm/state/snapshot.go	Enhanced the Snapshot struct to manage execute requests, including new context initialization and commit logic.
x/evm/types/keys.go	Introduced a new constant CONTEXT_KEY_PARENT_EXECUTE_REQUESTS for managing parent execute requests.

Suggested reviewers

• djm07073

Poem

I'm a rabbit with nimble paws,
Hoping through code without a pause.
Block SDK routes now brightly gleam,
Upgrades and docs flow like a dream.
With bytecode and JSON dancing in sight,
I nibble on bugs with pure delight! 🐇
Happy coding in our blockchain night!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package injective: could not load export data: no export data for "github.com/cosmos/relayer/v2/relayer/codecs/injective""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7afb0e and ff111ff.

📒 Files selected for processing (1)

• x/evm/keeper/context.go (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• x/evm/keeper/context.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Run test and upload codecov

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (4)

x/evm/contracts/erc20_wrapper/ERC20Wrapper.sol (1)

233-235: Improved JSON string handling in IBC transfer message.

The changes properly utilize JSONUTILS_CONTRACT.stringify_json() to ensure correct JSON formatting for the channel, receiver, and memo fields. This prevents potential issues with special characters and improves the overall robustness of the IBC message construction.

Also applies to: 245-247, 253-253

x/evm/keeper/context.go (1)

301-307: Improved error reporting for simulation and check modes.

This change enhances error transparency by returning the actual error instead of a generic out-of-gas error in simulation, re-check, and check execution modes when gas is depleted.

Consider adding a brief comment explaining why this special error handling is only needed for these specific execution modes but not for others.

client/docs/swagger-ui/swagger.yaml (1)

72287-72422: Definition Duplication & Consistency Recommendation

The definitions for sdk.auction.v1.Params, sdk.auction.v1.QueryParamsResponse, and sdk.mempool.v1.GetTxDistributionResponse are introduced separately in this hunk. To reduce duplication and ensure consistency, consider referencing these definitions via $ref in the endpoint responses instead of duplicating the schema inline. This refactoring step can simplify future modifications and maintain consistency across your API documentation.

x/evm/contracts/connect_oracle/ConnectOracle.sol (1)

20-27: Improved JSON string construction in get_price function.

The refactored code uses abi.encodePacked and JSONUTILS_CONTRACT.stringify_json to create the JSON request string, which is cleaner and more maintainable than the previous implementation.

Consider adding a comment explaining that stringify_json handles proper JSON escaping for the string parameter, which helps clarify why this approach is safer than manual string concatenation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4590f21 and 22ec8fd.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (18)

• app/app.go (3 hunks)
• app/genesis.go (1 hunks)
• app/ibc-hooks/README.md (1 hunks)
• app/keepers/keepers.go (0 hunks)
• app/upgrade.go (2 hunks)
• client/docs/config.json (1 hunks)
• client/docs/swagger-ui/swagger.yaml (2 hunks)
• go.mod (4 hunks)
• scripts/protoc-swagger-gen.sh (3 hunks)
• x/evm/contracts/connect_oracle/ConnectOracle.go (1 hunks)
• x/evm/contracts/connect_oracle/ConnectOracle.sol (3 hunks)
• x/evm/contracts/erc20_wrapper/ERC20Wrapper.go (1 hunks)
• x/evm/contracts/erc20_wrapper/ERC20Wrapper.sol (2 hunks)
• x/evm/keeper/context.go (4 hunks)
• x/evm/keeper/keeper.go (0 hunks)
• x/evm/keeper/precompiles.go (1 hunks)
• x/evm/precompiles/cosmos/contract.go (3 hunks)
• x/evm/precompiles/cosmos/types.go (1 hunks)

💤 Files with no reviewable changes (2)

• x/evm/keeper/keeper.go
• app/keepers/keepers.go

✅ Files skipped from review due to trivial changes (1)

• x/evm/contracts/connect_oracle/ConnectOracle.go

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Run test and upload codecov
• GitHub Check: golangci-lint
• GitHub Check: Minitiad
• GitHub Check: Analyze (go)

🔇 Additional comments (23)

x/evm/keeper/precompiles.go (1)

54-59: Addition of JSONUtilsPrecompileAddress looks good.

The precompileAddrs method has been correctly extended to include the new JSON utilities precompile address alongside the existing precompile addresses.

app/genesis.go (1)

130-130: Configure gas limit for hook operations.

Added a 3,000,000 gas limit for hook operations in the OP child module parameters. This sets an explicit upper bound for hook execution, which is a good security practice.

x/evm/precompiles/cosmos/contract.go (3)

151-152: Field rename from Address to Account is consistent with types.go.

The field reference has been updated from Address to Account to maintain consistency with changes in the underlying type definitions.

---

172-173: Field rename from Address to Account is consistent with types.go.

The field reference has been updated from Address to Account to maintain consistency with changes in the underlying type definitions.

---

195-196: Field rename from Address to Account is consistent with types.go.

The field reference has been updated from Address to Account to maintain consistency with changes in the underlying type definitions.

client/docs/config.json (2)

199-206: LGTM! API documentation properly expanded for auction module.

The added entry correctly integrates the auction SDK's query Swagger JSON with proper parameter renaming to avoid conflicts.

---

207-209: LGTM! Mempool API documentation properly integrated.

The entry for the mempool SDK's query Swagger JSON is correctly added to the API documentation system.

app/upgrade.go (2)

25-25: Version increment looks good.

Upgrade name updated to reflect the new version 0.7.3.

---

83-83: Improved upgrade handling with module migrations.

The change enhances the upgrade process by running migrations through the ModuleManager instead of directly returning the version map, ensuring all necessary module migrations are executed properly.

scripts/protoc-swagger-gen.sh (2)

14-15: LGTM! Block SDK integration variables properly defined.

The Block SDK URL and version variables are correctly defined, and the version extraction logic is consistent with other dependencies.

Also applies to: 23-23

---

33-33: Block SDK integration completed correctly.

The script properly clones the Block SDK repository with the correct version and includes its proto directories in the generation process.

Also applies to: 47-47

x/evm/keeper/context.go (3)

220-220: Documentation updated for reduced recursive depth limit.

The comment now correctly indicates that the maximum recursive depth is 8 (previously 16). This change is important as it affects the allowed EVM execution context nesting.

---

410-416: Improved error reporting for contract creation.

Similar to the previous change, this enhances error reporting when creating contracts in simulation, re-check, and check modes.

---

511-517: Enhanced panic handling for out-of-gas errors.

This change properly differentiates between out-of-gas panics (which should be propagated) and other types of panics (which should be converted to error messages). This distinction is important for proper gas accounting and error reporting.

x/evm/precompiles/cosmos/types.go (1)

11-11:

✅ Verification successful

Renamed fields from 'Address' to 'Account' for clarity.

The field name change from Address to Account in all three structures provides better semantics to clearly indicate these are blockchain accounts rather than generic addresses.

Also applies to: 16-16, 21-21

---

🏁 Script executed:

#!/bin/bash
# Check if any method calls still use the old parameter name "address"

echo "Checking for any usage of the old parameter name in contract.go..."
rg -A 3 "IsBlockedAddress|IsModuleAddress|IsAuthorityAddress" x/evm/precompiles/cosmos/contract.go

Length of output: 963

---

Field Renaming Verified: Consistent Usage of 'Account' Confirmed

• The renaming from Address to Account in all three structures in x/evm/precompiles/cosmos/types.go (lines 11, 16, and 21) has been applied consistently, improving semantics by clearly indicating blockchain accounts.
• The search in x/evm/precompiles/cosmos/contract.go did not reveal any lingering references to the old parameter name, confirming that no outdated usage remains.

Renamed fields from 'Address' to 'Account' for clarity. The changes are correctly propagated to all related structures and usages.

app/app.go (3)

64-65: Added Block SDK imports.

New imports from the Block SDK to support mempool functionality.

---

481-482: Added Block SDK mempool API route registration.

This addition registers the Block SDK mempool API routes with the gRPC gateway, enhancing the API capabilities with new mempool functionality.

---

505-511:

✅ Verification successful

Added Block SDK mempool transaction service registration.

This change properly registers the Block SDK mempool transaction service and includes a type assertion to ensure the application's mempool implements the required interface.

---

🏁 Script executed:

#!/bin/bash
# Check if this mempool type assertion might fail in some contexts

# Look for alternative mempool implementations that might be used
echo "Checking for mempool implementations in the codebase..."
rg -A 3 "type.*Mempool" --include="*.go"

# Check for tests that might be affected by this change
echo "Checking for tests that set up a mempool..."
rg -A 3 "SetMempool" --include="*_test.go"

Length of output: 1187

---

Updated Block SDK Mempool Registration – Manual Verification Needed

The changes in app/app.go (lines 505–511) correctly register the Block SDK mempool transaction service with a type assertion, ensuring that the application’s mempool conforms to the expected block.Mempool interface. However, please note that our earlier attempt to search for mempool references using the --include flag encountered errors. As a precaution, manually re-run the updated search commands (shown above) to verify that no alternative mempool implementations or tests (e.g., those referencing SetMempool) are negatively impacted by this change.

---

🏁 Script executed:

[run_scripts]
#!/bin/bash
echo "Checking for mempool implementations in the codebase with updated parameters..."
rg -g '*.go' -A 3 "type\s+.*Mempool"

echo "Checking for tests that set up a mempool with updated parameters..."
rg -g '*_test.go' -A 3 "SetMempool"

Length of output: 667

---

Block SDK Mempool Registration Verified and Approved

The registration code in app/app.go correctly asserts that the application’s mempool implements the block.Mempool interface. Our updated search revealed one mempool implementation in indexer/mempool.go (a MempoolWrapper), but it appears independent and does not impact the service registration. Additionally, no tests referencing SetMempool were found, suggesting that this change will not break any test expectations.

client/docs/swagger-ui/swagger.yaml (1)

44225-44376: New API Endpoints for Auction and Mempool

The new endpoints /block-sdk/auction/v1/params and /block-sdk/mempool/v1/distribution are clearly defined with detailed response schemas. The descriptions and property definitions (e.g., for max_bundle_size, escrow_account_address, and reserve_fee) are well-articulated. Please double-check that the data types (for instance, using string with format uint64 for numerical values in the transaction distribution) are consistent with your overall API design and meet client expectations.

x/evm/contracts/connect_oracle/ConnectOracle.sol (2)

39-45: More efficient JSON construction for get_prices function.

The implementation now uses abi.encodePacked with marshal_string_array to properly format the JSON request, improving code readability and maintainability.

---

64-76:

✅ Verification successful

Well-structured marshal_string_array function implementation.

The new function properly handles JSON array formatting with appropriate comma separators and brackets. The use of JSONUTILS_CONTRACT.stringify_json ensures proper escaping of individual string elements.

---

🏁 Script executed:

#!/bin/bash
# Check if this function is used in other contracts for potential reuse opportunities

rg -A 2 -B 2 "marshal_string_array" --type sol

Length of output: 74

---

Review Comment: JSON Marshal Function Approval & Verification Needed

The implementation of marshal_string_array in x/evm/contracts/connect_oracle/ConnectOracle.sol is clear and well-structured. The function correctly formats a JSON array by adding commas and brackets, and it leverages JSONUTILS_CONTRACT.stringify_json to ensure proper escaping of each string element.

Note: The previous search command using --type sol failed due to an unrecognized file type. Please verify manually (using the above command or similar) that this function isn’t used elsewhere in the repository for potential reuse opportunities.

---

🏁 Script executed:

[run_scripts]
#!/bin/bash
# Searching for occurrences of the "marshal_string_array" function in Solidity files 
# using a glob pattern for file names instead of relying on an unrecognized file type.
rg -A 2 -B 2 "function marshal_string_array" -g "*.sol"

Length of output: 545

---

Review Summary: JSON Marshalling Function Verified and Approved

The implementation of marshal_string_array in x/evm/contracts/connect_oracle/ConnectOracle.sol is correctly handling JSON array formatting by concatenating elements with commas and surrounding brackets. The use of JSONUTILS_CONTRACT.stringify_json properly escapes each string element, ensuring valid JSON output.

• Verification Details:
  • A search using rg with a glob pattern confirmed that this function is present exclusively in ConnectOracle.sol and is not reused elsewhere.

Based on this verification, no further changes are required.

go.mod (2)

20-20:

❓ Verification inconclusive

Dependency version updates for improved security and features.

The updates to multiple dependencies indicate regular maintenance to incorporate bug fixes, security patches, and new features from upstream libraries.

Also applies to: 22-22, 25-25, 37-37, 45-45, 51-51, 109-109

---

🏁 Script executed:

#!/bin/bash
# Check for any changes in changelogs or release notes for these updated dependencies

echo "Checking cosmos-sdk changelog for changes between v0.50.11 and v0.50.12"
curl -s https://raw.githubusercontent.com/cosmos/cosmos-sdk/main/CHANGELOG.md | grep -A 20 "v0.50.12"

echo "Checking OPinit changelog for changes between v0.7.0 and v0.7.2"
curl -s https://raw.githubusercontent.com/initia-labs/OPinit/main/CHANGELOG.md | grep -A 20 "v0.7.2"

Length of output: 492

---

Dependency Update Verification Needed

The dependency updates reflect routine maintenance aimed at incorporating upstream bug fixes, security patches, and new features. However, the automated changelog checks for cosmos-sdk (v0.50.12) and OPinit (v0.7.2) did not yield any output, making it unclear whether the expected changes are documented. Please perform a manual verification of these changelog entries to ensure that the updates indeed include the intended improvements.

• Confirm that the updated dependency for github.com/cosmos/cosmos-db v1.1.1 is consistent with upstream releases.
• Manually verify the changelogs for cosmos-sdk (comparing v0.50.11 → v0.50.12) and OPinit (comparing v0.7.0 → v0.7.2) to ensure that key updates, bug fixes, and security patches are applied.
• The same verification is recommended for the dependency updates on lines 22, 25, 37, 45, 51, and 109.

---

291-294:

✅ Verification successful

Added replace directive to fix statesync issue.

The new replace directive points to a specific fork/commit of the IAVL package to address a statesync problem referenced in a Cosmos SDK issue.

---

🌐 Web query:

What is the issue with statesync in Cosmos SDK issue #23740?

💡 Result:

The issue reported in Cosmos SDK GitHub issue #23740 involves state sync failing silently without clear error messages, leaving nodes stuck during synchronization. Here's a breakdown:

Key Symptoms

• Nodes stall at specific block heights (e.g., target=2305, height=2305) without progressing further[10].
• Logs show repeated attempts to fetch snapshots but no success:

  attempting to sync... module=statesync
  discovering snapshots for 15s
  discovering snapshots for 15s
  

• No explicit errors in logs despite configuration appearing correct[10].

Suspected Causes

1. Snapshot Interval Mismatch: The snapshot interval (e.g., snapshot-interval=1000) might conflict with how state sync calculates trusted block heights[10].
2. RPC Server Configuration: Potential issues with RPC endpoints not providing valid snapshots or headers[10].
3. Cosmos SDK Bugs: Similar historical issues (e.g., #13766) arose when snapshotting wasn't properly enabled in SDK versions ≥v0.46[3][7].

Current Status

• The issue remains open and under investigation as of February 2025[10].
• Users experiencing this are advised to:
  • Verify snapshot intervals match across nodes[1][6].
  • Ensure RPC servers are correctly configured and responsive[8][9].
  • Monitor community channels like Discord for workarounds while awaiting an official fix[1][10].

This problem highlights ongoing challenges in Cosmos SDK's state sync implementation, particularly around error handling and snapshot management.

Citations:

• 1: https://docs.scrt.network/secret-network-documentation/infrastructure/running-a-node-validator/setting-up-a-node-validator/node-setup/state-sync
• 2: https://forum.cosmos.network/t/erros-while-trying-to-launch-a-fullnode-on-mainnet/12271
• 3: State sync not working without having state sync snapshotting enabled cosmos/cosmos-sdk#13766
• 4: https://forum.cosmos.network/t/cant-verify-for-mainnet-on-local-node/10289
• 5: https://docs.humans.ai/validator/setup-and-configuration/state-sync
• 6: https://docs.evmos.org/validate/setup-and-configuration/state-sync
• 7: https://blog.cosmos.network/cosmos-sdk-state-sync-guide-99e4cf43be2f
• 8: https://docs.tendermint.com/v0.34/tendermint-core/state-sync.html
• 9: https://forum.cosmos.network/t/question-state-sync-with-only-one-node-over-rpc/5814
• 10: [Bug]: statesync is failing without any notable errors cosmos/cosmos-sdk#23740

---

Update on IAVL Replacement in go.mod to Address State Sync Issue
The replace directive added in go.mod (lines 291–294) temporarily points github.com/cosmos/iavl to the fork at commit caf697dd4712 from github.com/initia-labs/iavl. This change is intended to mitigate the silent state sync failures described in Cosmos SDK issue #23740, where nodes stall during synchronization without clear error messages.

• Context: The issue involves nodes failing to progress (e.g., getting stuck at a block height) and repeatedly attempting to sync snapshots without success.
• Temporary Fix: This replace directive serves as a stopgap measure until an official resolution is provided upstream.
• Next Steps: When upstream fixes or improvements become available, revisit this temporary directive to ensure long-term compatibility.

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Updated ERC20Wrapper contract bytecode.

The compiled bytecode for the ERC20Wrapper contract has been updated. This is auto-generated code from the underlying Solidity contract changes.

---

🏁 Script executed:

#!/bin/bash
# Verify the Solidity compiler version used for this bytecode

# Extract compiler version stamp from the bytecode (last 10 bytes of the bytecode)
BYTECODE_EXCERPT=$(echo "${Erc20WrapperMetaData.Bin: -20}" | tail -c 20)
echo "Compiler version stamp from bytecode: $BYTECODE_EXCERPT"

# Check if there are any recent changes to the ERC20Wrapper Solidity contract
git log -n 3 --oneline -- "**/ERC20Wrapper.sol"

Length of output: 242

---

Updated ERC20Wrapper Bytecode Verified – Verification Script Update Required

The ERC20Wrapper contract’s auto-generated bytecode has been updated as expected with the recent Solidity contract changes. However, the verification script that extracts the Solidity compiler version stamp is failing with a “bad substitution” error. This appears to be due to the use of a negative substring expansion (i.e. ${Erc20WrapperMetaData.Bin: -20}), which isn’t supported in the current shell environment.

Action Items:

• Update the extraction command for the compiler version stamp to a shell-compatible alternative (for example, using rev | cut -c1-20 | rev or a suitable sed command). This will ensure that the stamp is correctly captured for verification.

[coderabbitai]

⚠️ Potential issue

Updated JSON memo format from object to string representation.

The memo field format has been changed from a direct JSON object to a string representation of a JSON object. This change affects how clients need to encode memos in ICS20 packets.

This change might break compatibility with existing clients that are sending memos as JSON objects rather than as strings. Make sure to:

1. Update client documentation to reflect this change
2. Ensure server code properly handles both formats during a transition period if possible
3. Verify that dependent systems are aware of this breaking change

The backend code should properly deserialize the string before processing the memo contents.

[codecov]

Codecov Report

Attention: Patch coverage is 68.57143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 57.16%. Comparing base (316533e) to head (ff111ff).

Files with missing lines	Patch %	Lines
x/evm/keeper/context.go	57.69%	10 Missing and 1 partial ⚠️
app/app.go	0.00%	9 Missing ⚠️
x/evm/precompiles/cosmos/contract.go	73.91%	4 Missing and 2 partials ⚠️
jsonrpc/namespaces/eth/filters/api.go	0.00%	2 Missing and 2 partials ⚠️
jsonrpc/namespaces/eth/filters/subscriptions.go	0.00%	1 Missing and 1 partial ⚠️
app/upgrade.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   57.08%   57.16%   +0.07%     
==========================================
  Files         114      115       +1     
  Lines       11061    11137      +76     
==========================================
+ Hits         6314     6366      +52     
- Misses       3810     3830      +20     
- Partials      937      941       +4     

Files with missing lines	Coverage Δ
app/genesis.go	92.02% <100.00%> (+0.05%)	⬆️
app/keepers/keepers.go	98.05% <ø> (-0.01%)	⬇️
x/evm/keeper/keeper.go	71.01% <ø> (-0.42%)	⬇️
x/evm/keeper/precompiles.go	75.67% <100.00%> (+3.80%)	⬆️
x/evm/precompiles/cosmos/types.go	100.00% <100.00%> (ø)
x/evm/precompiles/erc20_registry/contract.go	55.85% <100.00%> (+1.22%)	⬆️
x/evm/precompiles/jsonutils/contract.go	65.85% <100.00%> (+0.50%)	⬆️
x/evm/state/snapshot.go	92.00% <100.00%> (+12.00%)	⬆️
x/evm/types/dispatch.go	0.00% <ø> (ø)
app/upgrade.go	3.61% <0.00%> (ø)
... and 5 more

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

x/evm/keeper/context_test.go (1)

438-468: LGTM: Test for execute requests behavior during revert

This test correctly verifies that the recursive_revert function works as expected by checking the emitted logs. The test helps ensure that execute requests are properly handled even when transactions are reverted.

However, consider adding explicit assertions that verify the execute requests are not cleaned on revert, which would more directly test the behavior implied by the test name.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 930a29f and 3e14118.

📒 Files selected for processing (5)

• x/evm/contracts/counter/Counter.go (3 hunks)
• x/evm/contracts/counter/Counter.sol (1 hunks)
• x/evm/keeper/context_test.go (1 hunks)
• x/evm/state/snapshot.go (2 hunks)
• x/evm/types/keys.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Run test and upload codecov
• GitHub Check: Minitiad

🔇 Additional comments (10)

x/evm/types/keys.go (1)

49-50: LGTM: New context key for parent execute requests

The addition of CONTEXT_KEY_PARENT_EXECUTE_REQUESTS as a new context key is well-documented and follows the existing pattern. This key will be used to track execute requests from parent contexts.

x/evm/contracts/counter/Counter.sol (2)

111-119: LGTM: New recursive_revert function

The recursive_revert function is well-implemented. It properly emits an event before attempting to call the nested function, and uses a try-catch block to handle any exceptions without propagating them.

---

121-125: LGTM: New nested_recursive_revert function

The nested_recursive_revert function correctly executes a Cosmos message using the existing _recursive helper function and then immediately reverts. This design creates a controlled test case for reversion after executing external calls.

x/evm/state/snapshot.go (3)

3-3: LGTM: Import added for types package

The import of the types package is necessary to access the new context keys.

---

11-18: LGTM: Enhanced snapshot initialization with parent execute requests tracking

The modifications to NewSnapshot correctly initialize the context with tracking for both parent and current execute requests, enabling proper propagation of requests between execution contexts.

---

28-32: LGTM: Properly propagating execute requests to parent context

The implementation correctly retrieves both parent and current execute requests from the context and appends the current requests to the parent's list, ensuring that execute requests are properly managed during context transitions.

x/evm/contracts/counter/Counter.go (4)

34-35: ABI and Bin updates align with the new function implementations.

The ABI and Bin fields in CounterMetaData have been updated to include the signatures for the two new functions: nested_recursive_revert and recursive_revert. These changes are necessary to support the new contract functionality.

---

414-433: Implementation for NestedRecursiveRevert looks good.

The implementation follows the consistent pattern used for other transaction methods in this generated file. The method is correctly exposed at all three levels: CounterTransactor, CounterSession, and CounterTransactorSession.

---

477-496: Implementation for RecursiveRevert looks good.

The implementation follows the consistent pattern used for other transaction methods in this generated file. The method is correctly exposed at all three levels: CounterTransactor, CounterSession, and CounterTransactorSession.

---

1-3: Note: This is an auto-generated file.

As indicated by the comment, this is a generated binding and manual changes will be lost during regeneration. The new methods appear to be properly generated using the same tools that generated the rest of the file.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

integration-tests/go.mod (1)

247-279: Dependency Replacement Consistency Check.
The replace directives (e.g., for github.com/99designs/keyring, github.com/dgrijalva/jwt-go, github.com/gin-gonic/gin, and others) remain critical for ensuring compatibility. Please verify that these replacements continue to work seamlessly with the updated dependencies and check particularly for any interactions with the dependency changes outlined in PR 349.

x/evm/contracts/i_cosmos/ICosmos.sol (2)

62-62:

❓ Verification inconclusive

Added gas limit parameter to execute_cosmos function.

The execute_cosmos function signature has been updated to include a uint64 gas_limit parameter. This change allows better control over gas consumption for cosmos message execution.

This is a breaking change to the interface. Please ensure that all callers of this function have been updated to provide the new parameter.

---

🏁 Script executed:

#!/bin/bash
# Search for all callers of execute_cosmos to ensure they're updated
rg "execute_cosmos\s*\(\s*[^,)]*\s*\)" --type solidity

Length of output: 89

---

Action Required: Verify All Callers for Updated execute_cosmos Signature

The execute_cosmos function in x/evm/contracts/i_cosmos/ICosmos.sol has been updated to include a uint64 gas_limit parameter:

function execute_cosmos(string memory msg, uint64 gas_limit) external returns (bool dummy);

This change is breaking. Please ensure that every caller of this function has been updated to supply the new parameter. Note that the previous shell script using --type solidity resulted in an error; re-run the search with a corrected command (which scopes to Solidity files) as follows:

#!/bin/bash
# Searching for all callers of execute_cosmos in Solidity files
rg "execute_cosmos\s*\(" -g "*.sol"

Manually verify the output of this command to confirm that all invocations now include the required gas_limit argument.

---

90-92:

❓ Verification inconclusive

Added gas limit parameter to execute_cosmos_with_options function.

The execute_cosmos_with_options function signature has been updated to include a uint64 gas_limit parameter. This change allows better control over gas consumption for cosmos message execution with options.

This is a breaking change to the interface. Please ensure that all callers of this function have been updated to provide the new parameter.

---

🏁 Script executed:

#!/bin/bash
# Search for all callers of execute_cosmos_with_options to ensure they're updated
rg "execute_cosmos_with_options\s*\(\s*[^,)]*\s*,\s*[^,)]*\s*\)" --type solidity

Length of output: 115

---

Action Required: Verify All Callers of execute_cosmos_with_options

The interface change adds a new uint64 gas_limit parameter to execute_cosmos_with_options, which is a breaking change. Please ensure that all invocations of this function across the codebase have been updated to supply the new parameter.

• In particular, confirm that in x/evm/contracts/i_cosmos/ICosmos.sol (lines 90-92) the updated signature is correctly implemented.
• Since our initial search command failed due to the unrecognized file type "solidity", re-run the search using a command that targets Solidity files, for example:

  rg "execute_cosmos_with_options\s*\(" --glob "*.sol"

• Manually verify the results to ensure that every caller now provides the gas_limit argument.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e14118 and c7afb0e.

⛔ Files ignored due to path filters (1)

• integration-tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (19)

• .github/workflows/docker.yml (0 hunks)
• integration-tests/go.mod (5 hunks)
• x/evm/contracts/counter/Counter.go (4 hunks)
• x/evm/contracts/counter/Counter.sol (4 hunks)
• x/evm/contracts/erc20_wrapper/ERC20Wrapper.go (2 hunks)
• x/evm/contracts/erc20_wrapper/ERC20Wrapper.sol (4 hunks)
• x/evm/contracts/i_cosmos/ICosmos.go (2 hunks)
• x/evm/contracts/i_cosmos/ICosmos.sol (2 hunks)
• x/evm/keeper/context.go (5 hunks)
• x/evm/keeper/context_test.go (6 hunks)
• x/evm/keeper/precompiles_test.go (3 hunks)
• x/evm/precompiles/cosmos/contract.go (7 hunks)
• x/evm/precompiles/cosmos/contract_test.go (16 hunks)
• x/evm/precompiles/cosmos/types.go (2 hunks)
• x/evm/precompiles/erc20_registry/contract.go (1 hunks)
• x/evm/precompiles/erc20_registry/contract_test.go (4 hunks)
• x/evm/precompiles/jsonutils/contract.go (1 hunks)
• x/evm/precompiles/jsonutils/contract_test.go (8 hunks)
• x/evm/types/dispatch.go (1 hunks)

💤 Files with no reviewable changes (1)

• .github/workflows/docker.yml

🚧 Files skipped from review as they are similar to previous changes (4)

• x/evm/keeper/context.go
• x/evm/precompiles/cosmos/contract.go
• x/evm/precompiles/cosmos/types.go
• x/evm/contracts/counter/Counter.sol

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Run test and upload codecov

🔇 Additional comments (56)

integration-tests/go.mod (10)

8-8: Dependency Update: cosmos-sdk Version Change.
The dependency on github.com/cosmos/cosmos-sdk has been upgraded to v0.50.12. Please verify that this version is compatible with the rest of the system and that any dependent modules (or external integrations) are adjusted accordingly.

---

68-68: Dependency Update: cosmos-db Version Change.
The update of github.com/cosmos/cosmos-db to v1.1.1 aligns with the audit fixes and upgrade objectives. Confirm that downstream modules relying on this dependency remain unaffected by the version bump.

---

73-73: Dependency Update: ibc-apps Middleware Version Change.
The github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v8 dependency is now at v8.1.1. Ensure that integration tests cover any behavioral changes that might come with this update.

---

78-78: Dependency Update: ledger-cosmos-go Version Update.
Upgrading github.com/cosmos/ledger-cosmos-go to v0.14.0 should bring necessary fixes and improvements. Please make sure that any components interacting with ledger functionality are tested for compatibility.

---

145-145: Dependency Update: OPinit Version Update.
The github.com/initia-labs/OPinit dependency has been updated to v0.7.2. Verify that any public API or behavioral changes in OPinit are well covered by integration tests.

---

150-150: Dependency Update: evm-tx Submodule Version Update.
The version of github.com/initia-labs/kvindexer/submodules/evm-tx has been increased to v0.1.6. Please confirm that this update is in line with related transaction processing logic and does not cause any regression.

---

152-152: Dependency Update: movevm Module Version Update.
The upgrade to github.com/initia-labs/movevm v0.7.0 is in keeping with the overall dependency alignment objectives. Ensure that any new or deprecated features from this version are accounted for in tests and documentation.

---

173-173: Dependency Update: forwarding Module Version Update.
The upgrade of github.com/noble-assets/forwarding/v2 to v2.0.1 should be validated against the usage scenarios in the integration tests. Monitor for any API changes that might affect functionality.

---

199-199: Dependency Update: spf13/cast Version Update.
The github.com/spf13/cast dependency now uses v1.7.1. Please review its usage across the project to ensure that there are no breaking changes in type conversion or other API behavior.

---

1-279: Overall Dependency Upgrade Verification.
All dependency versions have been updated as required by the audit fixes and upgrade objectives. It is recommended to run the full integration test suite to confirm that there are no breaking changes or regressions. Additionally, double-check that the temporary replace directives and indirect dependency updates are consistent with the root-level dependency management.

x/evm/types/dispatch.go (1)

17-19: Good addition of the GasLimit field to ExecuteRequest.

Adding the gas limit field to the ExecuteRequest struct enhances the contract execution capabilities by allowing explicit gas control, which aligns with the broader gas management improvements across the codebase.

x/evm/precompiles/erc20_registry/contract_test.go (4)

90-92: Improved error handling for gas-related test cases.

The test now properly checks for the execution reverted error and verifies that the output contains "out of gas", which is more consistent with how the EVM handles gas errors.

---

108-110: Consistent error handling approach for gas limit tests.

This change follows the same pattern of checking for ErrExecutionReverted and validating the output message, maintaining consistency with the previous change.

---

141-143: Standardized gas limit error verification.

The update follows the standard error handling pattern established in the previous test cases, ensuring a consistent approach throughout the file.

---

159-161: Aligned panic test with updated error handling approach.

The out of gas panic test now correctly checks for ErrExecutionReverted and validates the error message, consistent with the error handling approach in other test cases.

x/evm/keeper/precompiles_test.go (6)

63-63: Added gas limit parameter to execute_cosmos call.

The addition of a 150,000 gas limit parameter to the execute_cosmos function call aligns with the updated function signature in the contracts, ensuring proper gas management during test execution.

---

292-292: Added consistent gas limit parameter.

This change adds the necessary gas limit parameter to another execute_cosmos call, maintaining consistency across function calls.

---

313-313: Gas limit parameter addition for contract function.

Adding the gas limit parameter here ensures that the test properly handles gas limitations in accordance with updated contract interfaces.

---

355-355: Added gas limit parameter to execute_cosmos_with_options.

The gas limit parameter addition ensures that this test case aligns with the updated function signature.

---

396-396: Consistent gas limit parameter added.

This change maintains consistency with the previous test cases by including the gas limit parameter.

---

414-414: Added required gas limit parameter.

The gas limit parameter is correctly added to the final test case, ensuring all test cases follow the updated function signature.

x/evm/keeper/context_test.go (6)

292-292: Added gas limit parameter to execute_cosmos function call.

The addition of a 120,000 gas limit parameter aligns with the updated function signature, ensuring proper gas management during contract execution testing.

---

313-313: Consistent gas limit parameter added.

This change maintains consistency with the previous function call by including the appropriate gas limit parameter.

---

355-355: Added gas limit parameter to execute_cosmos_with_options.

The gas limit parameter ensures this test follows the updated function signature and properly tests gas limit handling.

---

396-396: Consistent gas limit parameter added.

This change follows the pattern established in previous test cases, maintaining consistency in how function calls are made.

---

414-414: Added required gas limit parameter.

The gas limit parameter is correctly included to match the updated function signature.

---

443-473: Good addition of a new test for recursive execution with revert.

This test effectively verifies that execute requests are properly handled even when revert occurs in a recursive call context. The test case helps ensure the system's resilience against potential contract execution issues.

x/evm/precompiles/erc20_registry/contract.go (2)

54-58: Improved error handling for out of gas conditions.

The error handling has been updated to provide a more descriptive error message when an out-of-gas condition occurs in the precompile. This change ensures that the gas accounting is correct by setting the used gas to the supplied gas.

---

66-67: Streamlined error handling logic.

The error handling has been simplified by removing the special case for out-of-gas errors. Now all errors are consistently converted to vm.ErrExecutionReverted with the appropriate revert reason, which improves debugging and error reporting.

x/evm/precompiles/jsonutils/contract.go (2)

63-67: Improved error handling for out of gas conditions.

The error handling has been updated to provide a more descriptive error message when an out-of-gas condition occurs in the precompile. This change ensures proper gas accounting by setting the used gas to the supplied gas.

---

73-76: Streamlined error handling logic.

The error handling has been simplified by removing the special case for out-of-gas errors. Now all errors are consistently converted to vm.ErrExecutionReverted with the appropriate revert reason, which improves debugging and error reporting.

x/evm/precompiles/cosmos/contract_test.go (5)

84-86: Updated error assertion to match new error handling.

The test has been updated to reflect the changes in error handling from vm.ErrOutOfGas to vm.ErrExecutionReverted with additional verification of the error message content.

---

130-132: Updated additional test cases to match new error handling pattern.

All test cases that previously checked for vm.ErrOutOfGas have been consistently updated to verify vm.ErrExecutionReverted with an appropriate error message check.

Also applies to: 175-177, 219-221, 251-253, 295-297, 374-376, 470-472, 517-519, 559-561

---

278-279: Added gas limit variable for testing.

A new contractExecGas variable has been introduced to clearly define the gas limit for contract execution in tests, improving readability and maintainability.

Also applies to: 356-357

---

291-291: Updated test data to include gas limit parameter.

The test data has been updated to include the newly required gas_limit parameter for the execute_cosmos and execute_cosmos_with_options functions.

Also applies to: 332-332, 370-370, 411-411

---

316-319: Updated expected execution request to include gas limit.

The test expectations have been updated to include the GasLimit field in the expected execution request, ensuring that the gas limit is properly passed through the system.

Also applies to: 395-398

x/evm/precompiles/jsonutils/contract_test.go (1)

108-110: Improved error handling for gas exhaustion scenarios

The error handling has been updated to check for vm.ErrExecutionReverted instead of a specific out-of-gas error, with an additional verification of the error message content. This change better aligns with Ethereum's behavior where out-of-gas conditions trigger execution reverts.

x/evm/contracts/erc20_wrapper/ERC20Wrapper.sol (2)

68-80: Enhanced gas control for IBC transfers

The addition of the gas_limit parameter to the wrap function provides fine-grained control over gas consumption during cross-chain transfers. The implementation maintains backward compatibility by having the existing function signatures delegate to the new implementation with a sensible default of 250,000 gas units.

---

246-260: Improved JSON formatting for IBC message construction

The IBC transfer message construction has been enhanced by using proper JSON utilities (JSONUTILS_CONTRACT.stringify_json) instead of string concatenation. This makes the code more robust against JSON formatting errors and improves maintainability.

x/evm/contracts/erc20_wrapper/ERC20Wrapper.go (2)

34-35: Updated contract bindings reflect Solidity contract changes

The auto-generated bindings have been properly updated to reflect the changes in the Solidity contract, including the updated ABI and bytecode.

---

476-495: Updated method bindings for new gas_limit parameter

The Go bindings for the Wrap0 method have been correctly updated to include the new gas_limit parameter, maintaining consistency with the Solidity contract changes.

x/evm/contracts/i_cosmos/ICosmos.go (2)

282-301: Enhanced ICosmos interface with gas management

The ICosmos interface has been consistently updated to include the gas_limit parameter in the execute_cosmos method, aligning with the changes in the contract implementations. This provides better control over gas consumption during cosmos message execution.

---

303-322: Consistent gas_limit parameter addition to ExecuteCosmosWithOptions

The execute_cosmos_with_options method has been similarly updated to include the gas_limit parameter, maintaining API consistency across the cosmos execution functions. This coordinated change ensures proper gas management throughout the codebase.

x/evm/contracts/counter/Counter.go (13)

34-35: Ensure ABI and BIN are in sync with recent contract changes
These lines typically update automatically after any Solidity contract modifications. It's good practice to verify that the generated ABI and BIN match the actual compiled contract.

Would you like to confirm these changes with an additional build or code search?

---

288-293: New signature for ExecuteCosmos
The function now accepts a gas_limit parameter, aligning with the updated contract. This appears correct given the ABI.

---

295-300: ExecuteCosmos session binding updated
The updated signature in the session method is consistent with the transactor method.

---

302-307: Consistency check for ExecuteCosmos in TransactorSession
All references to the new parameter (gas_limit) look properly wired.

---

309-314: ExecuteCosmosWithOptions extended
The added argument list matches the contract method signatures for gas control and callback logic.

---

316-321: Session binding for ExecuteCosmosWithOptions
The updated function signature is correct as per the new contract definition.

---

323-328: ExecuteCosmosWithOptions in TransactorSession
All parameters, including gas_limit and allow_failure, align with the ABI.

---

414-419: New NestedRecursiveRevert transactor method
This newly exposed function for nested recursion and revert behavior matches the ABI. Consider adding thorough tests that verify revert conditions.

---

421-426: NestedRecursiveRevert in Session
The session version’s signature and call flow correctly follow the transactor method above.

---

428-433: NestedRecursiveRevert in TransactorSession
All parameters are passed as expected. Ensure testing covers the revert paths.

---

477-482: Introduction of RecursiveRevert in Transactor
Ensure your contract logic for “recursive_revert” is tested extensively to cover edge cases.

---

484-489: RecursiveRevert in Session
Matches the contract signature for revert testing scenarios.

---

491-496: RecursiveRevert in TransactorSession
No issues spotted. This final binding is consistent with the rest.