Fix: avoid fetching file status after navigating

matiasgarciaisaia · matiasgarciaisaia · commit 6ad6f921c75c · 2024-12-09T18:24:34.000-03:00
Without invalidating the timer, navigating from one survey to another would keep the status for both surveys' files to be fetched, yielding bugs in the UI. See #2350 See #2362
diff --git a/assets/js/components/respondents/RespondentIndex.jsx b/assets/js/components/respondents/RespondentIndex.jsx
@@ -102,6 +102,14 @@ class RespondentIndex extends Component<Props, State> {
     }
   }
 
+  componentWillUnmount() {
+    const timer = this.state.filesFetchTimer
+    if (timer) {
+      clearInterval(timer)
+      this.setState({filesFetchTimer: null})
+    }
+  }
+
   fetchRespondents(pageNumber = 1, overrideFilter = null) {
     const { projectId, surveyId, pageSize, filter, sortBy, sortAsc } = this.props
     const _filter = overrideFilter == null ? filter : overrideFilter

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,14 @@ class RespondentIndex extends Component<Props, State> {`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`
	`105`	`+ componentWillUnmount() {`
	`106`	`+ const timer = this.state.filesFetchTimer`
	`107`	`+ if (timer) {`
	`108`	`+ clearInterval(timer)`
	`109`	`+ this.setState({filesFetchTimer: null})`
	`110`	`+ }`
	`111`	`+ }`
	`112`	`+`
`105`	`113`	`fetchRespondents(pageNumber = 1, overrideFilter = null) {`
`106`	`114`	`const { projectId, surveyId, pageSize, filter, sortBy, sortAsc } = this.props`
`107`	`115`	`const _filter = overrideFilter == null ? filter : overrideFilter`