fix: forbid compression for pre-xe2 platforms

Related-To: NEO-9465
Signed-off-by: Jaroslaw Warchulski <[email protected]>
Source: df07897

Author: jwarchul

shared/source/gen12lp/linux/product_helper_adlp.cpp

@@ -26,10 +26,5 @@ int ProductHelperHw<gfxProduct>::configureHardwareCustom(HardwareInfo *hwInfo, O
     return 0;
 }
 
-template <>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(true);
-}
-
 template class ProductHelperHw<gfxProduct>;
 } // namespace NEO

shared/source/gen12lp/linux/product_helper_dg1.cpp

@@ -29,10 +29,5 @@ int ProductHelperHw<gfxProduct>::configureHardwareCustom(HardwareInfo *hwInfo, O
     return 0;
 }
 
-template <>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(true);
-}
-
 template class ProductHelperHw<gfxProduct>;
 } // namespace NEO

shared/source/gen12lp/linux/product_helper_rkl.cpp

@@ -26,10 +26,5 @@ int ProductHelperHw<gfxProduct>::configureHardwareCustom(HardwareInfo *hwInfo, O
     return 0;
 }
 
-template <>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(true);
-}
-
 template class ProductHelperHw<gfxProduct>;
 } // namespace NEO

shared/source/gen12lp/linux/product_helper_tgllp.cpp

@@ -26,10 +26,5 @@ int ProductHelperHw<gfxProduct>::configureHardwareCustom(HardwareInfo *hwInfo, O
     return 0;
 }
 
-template <>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(true);
-}
-
 template class ProductHelperHw<gfxProduct>;
 } // namespace NEO

shared/source/os_interface/product_helper.inl

@@ -1111,9 +1111,4 @@ bool ProductHelperHw<gfxProduct>::isCompressionForbiddenCommon(bool defaultValue
     }
 }
 
-template <PRODUCT_FAMILY gfxProduct>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(false);
-}
-
 } // namespace NEO

shared/source/os_interface/product_helper_before_xe2.inl

@@ -40,4 +40,9 @@ void ProductHelperHw<gfxProduct>::setRenderCompressedFlags(HardwareInfo &hwInfo)
     hwInfo.capabilityTable.ftrRenderCompressedBuffers = hwInfo.featureTable.flags.ftrE2ECompression;
 }
 
+template <PRODUCT_FAMILY gfxProduct>
+bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
+    return isCompressionForbiddenCommon(true);
+}
+
 } // namespace NEO

shared/source/os_interface/product_helper_xe2_and_later.inl

@@ -44,4 +44,9 @@ void ProductHelperHw<gfxProduct>::setRenderCompressedFlags(HardwareInfo &hwInfo)
     hwInfo.capabilityTable.ftrRenderCompressedBuffers = hwInfo.featureTable.flags.ftrXe2Compression;
 }
 
+template <PRODUCT_FAMILY gfxProduct>
+bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
+    return isCompressionForbiddenCommon(false);
+}
+
 } // namespace NEO

shared/source/xe_hpg_core/xe_lpg/linux/product_helper_xe_lpg_linux.inl

@@ -49,9 +49,4 @@ bool ProductHelperHw<gfxProduct>::useGemCreateExtInAllocateMemoryByKMD() const {
     return true;
 }
 
-template <>
-bool ProductHelperHw<gfxProduct>::isCompressionForbidden(const HardwareInfo &hwInfo) const {
-    return isCompressionForbiddenCommon(true);
-}
-
 } // namespace NEO

shared/test/unit_test/os_interface/product_helper_tests.cpp

@@ -1155,3 +1155,13 @@ HWTEST_F(ProductHelperTest, givenProductHelperWhenCheckingIsCompressionForbidden
     debugManager.flags.RenderCompressedImagesEnabled.set(1);
     EXPECT_FALSE(productHelper->isCompressionForbidden(hwInfo));
 }
+
+HWTEST2_F(ProductHelperTest, givenProductHelperThenCompressionIsForbidden, IsBeforeXe2HpgCore) {
+    auto hwInfo = *defaultHwInfo;
+    EXPECT_TRUE(productHelper->isCompressionForbidden(hwInfo));
+}
+
+HWTEST2_F(ProductHelperTest, givenProductHelperThenCompressionIsNotForbidden, IsAtLeastXe2HpgCore) {
+    auto hwInfo = *defaultHwInfo;
+    EXPECT_FALSE(productHelper->isCompressionForbidden(hwInfo));
+}

shared/test/unit_test/xe_hpg_core/arl/linux/product_helper_tests_arl.cpp

@@ -98,8 +98,3 @@ ARLTEST_F(ArlProductHelperLinux, givenBooleanUncachedWhenCallOverridePatIndexThe
     EXPECT_EQ(0u, productHelper->overridePatIndex(isUncached, patIndex, AllocationType::buffer));
     EXPECT_EQ(3u, productHelper->overridePatIndex(isUncached, patIndex, AllocationType::commandBuffer));
 }
-
-ARLTEST_F(ArlProductHelperLinux, givenProductHelperThenCompressionIsNotAllowed) {
-    auto hwInfo = *defaultHwInfo;
-    EXPECT_TRUE(productHelper->isCompressionForbidden(hwInfo));
-}

shared/test/unit_test/xe_hpg_core/mtl/linux/product_helper_tests_mtl_linux.cpp

@@ -73,8 +73,3 @@ MTLTEST_F(MtlProductHelperLinux, givenBooleanUncachedWhenCallOverridePatIndexThe
     EXPECT_EQ(0u, productHelper->overridePatIndex(isUncached, patIndex, AllocationType::buffer));
     EXPECT_EQ(3u, productHelper->overridePatIndex(isUncached, patIndex, AllocationType::commandBuffer));
 }
-
-MTLTEST_F(MtlProductHelperLinux, givenProductHelperThenCompressionIsNotAllowed) {
-    auto hwInfo = *defaultHwInfo;
-    EXPECT_TRUE(productHelper->isCompressionForbidden(hwInfo));
-}