Skip to content

Commit 0fafd6e

Browse files
authored
fix: isInitializing true on first render after connected user reloads page (#256)
1 parent db3c8fa commit 0fafd6e

File tree

7 files changed

+22
-12
lines changed

7 files changed

+22
-12
lines changed

docs/pages/getting-started/installation.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The bundle needs peer dependencies, be sure that following resources are availab
4646
as well:
4747

4848
```sh npm2yarn
49-
npm i @dfinity/ledger-icp @dfinity/identity @dfinity/agent @dfinity/candid @dfinity/identity @dfinity/principal @dfinity/utils @dfinity/auth-client
49+
npm i @dfinity/ledger-icp @dfinity/identity @dfinity/agent @dfinity/candid @dfinity/principal @dfinity/utils @dfinity/auth-client
5050
```
5151

5252
> Note: IdentityKit is a React library and exports styles that need to be imported into your

docs/theme.config.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ const theme = {
4848
light: 38,
4949
},
5050
banner: {
51-
key: "1.0.2-release",
51+
key: "1.0.3-release",
5252
content: (
5353
<a href="https://www.npmjs.com/package/@nfid/identitykit" target="_blank">
54-
🎉 @nfid/[email protected].2 is released.
54+
🎉 @nfid/[email protected].3 is released.
5555
</a>
5656
),
5757
},

examples/react-dapp/src/ui/molecules/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const Header = () => {
3535
href="https://www.npmjs.com/package/@nfid/identitykit"
3636
className="absolute text-[10px] text-primary dark:text-teal-500 text-right right-0 bottom-0 mb-[-10px] me-[-10px]"
3737
>
38-
v1.0.2
38+
v1.0.3
3939
</a>
4040
</div>
4141
<div className="flex items-center space-x-2 sm:space-x-4">

examples/react-demo/src/ui/molecules/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export const Header = () => {
3232
href="https://www.npmjs.com/package/@nfid/identitykit"
3333
className="absolute text-[10px] text-primary dark:text-teal-500 text-right right-0 bottom-0 mb-[-10px] me-[-10px]"
3434
>
35-
v1.0.2
35+
v1.0.3
3636
</a>
3737
</div>
3838
<div className="flex items-center space-x-2 sm:space-x-4">

package-lock.json

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/identitykit/package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nfid/identitykit",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"description": "A React library for adding wallet connections to dApps.",
55
"keywords": [
66
"ICP",
@@ -121,6 +121,10 @@
121121
"peerDependencies": {
122122
"@dfinity/auth-client": ">=2.1.3",
123123
"@dfinity/ledger-icp": ">=2.4.0",
124+
"@dfinity/identity": ">=2.1.3",
125+
"@dfinity/agent": ">=2.1.3",
126+
"@dfinity/candid": ">=2.1.3",
127+
"@dfinity/principal": ">=2.1.3",
124128
"react": ">=18.3.1",
125129
"react-dom": ">=18.3.1"
126130
},

packages/identitykit/src/libs/react/hooks/use-proceed-signer.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ export function useProceedSigner({
2626
>
2727
}) {
2828
// saved to local storage for next js (localStorage is not defined during server render)
29-
const [localStorageSigner, setLocalStorageSigner] = useState<string | undefined>()
29+
const [localStorageSigner, setLocalStorageSigner] = useState<string | undefined>(
30+
(typeof window !== "undefined" && localStorage.getItem("signerId")) || ""
31+
)
3032
const [selectedSigner, setSelectedSigner] = useState<
3133
{ signer: Signer<Transport>; signerId?: string } | undefined
3234
>(undefined)
@@ -88,10 +90,10 @@ export function useProceedSigner({
8890

8991
// default selected signer from local storage
9092
useEffect(() => {
91-
const storageSigner = localStorage.getItem("signerId")
92-
if (!selectedSigner && storageSigner) {
93-
setLocalStorageSigner(storageSigner)
94-
selectSigner(storageSigner)
93+
// for next.js, where localStorage is not available during ssr
94+
const lsSigner = localStorage.getItem("signerId")
95+
if (!selectedSigner && lsSigner) {
96+
selectSigner(lsSigner)
9597
}
9698
}, [selectedSigner, selectSigner])
9799

0 commit comments

Comments
 (0)