fix([sc-15475]): extended popup transport establishTimeout to 1 min (#251)

olekid · web-flow · commit e826e2f83cf9 · 2024-11-29T18:25:19.000+04:00
fix([sc-16068]): standards and demo page titles
diff --git a/examples/react-dapp/index.html b/examples/react-dapp/index.html
@@ -1,22 +1,18 @@
 <!doctype html>
 <html lang="en">
-  <head>
-    <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="/favicon.ico" />
-    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <!-- <meta name="color-scheme" content="dark">  -->
-    <title>Identity Kit Playground</title>
-    <link
-      href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&display=swap"
-      rel="stylesheet"
-    />
-    <link
-      href="https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=swap"
-      rel="stylesheet"
-    />
-  </head>
-  <body>
-    <div id="root"></div>
-    <script type="module" src="/src/main.tsx"></script>
-  </body>
-</html>
+
+<head>
+  <meta charset="UTF-8" />
+  <link rel="icon" type="image/svg+xml" href="/favicon.ico" />
+  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+  <title>NFID IdentityKit | Standards</title>
+  <link href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&display=swap" rel="stylesheet" />
+  <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=swap" rel="stylesheet" />
+</head>
+
+<body>
+  <div id="root"></div>
+  <script type="module" src="/src/main.tsx"></script>
+</body>
+
+</html>
diff --git a/examples/react-demo/index.html b/examples/react-demo/index.html
@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <link rel="icon" type="image/svg+xml" href="/favicon.ico" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>Identity Kit Playground</title>
+    <title>NFID IdentityKit | Demo</title>
     <link
       href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&display=swap"
       rel="stylesheet"
diff --git a/packages/identitykit/src/lib/service/transport-builder/new-tab-transport.builder.spec.ts b/packages/identitykit/src/lib/service/transport-builder/new-tab-transport.builder.spec.ts
@@ -1,5 +1,8 @@
 import { PostMessageTransport, PostMessageTransportOptions } from "@slide-computer/signer-web"
-import { getPopupTransportBuilder } from "./new-tab-transport.builder"
+import {
+  getPopupTransportBuilder,
+  NEW_TAB_TRANSPORT_DEFAULT_ESTABLISH_TIMEOUT,
+} from "./new-tab-transport.builder"
 
 jest.mock("@slide-computer/signer-web", () => ({
   PostMessageTransport: jest.fn(),
@@ -25,7 +28,7 @@ describe("getPopupTransportBuilder", () => {
     await getPopupTransportBuilder(request)
     expect(PostMessageTransport).toHaveBeenCalledWith({
       url: mockUrl,
-      establishTimeout: 15000,
+      establishTimeout: NEW_TAB_TRANSPORT_DEFAULT_ESTABLISH_TIMEOUT,
     })
   })
 })
diff --git a/packages/identitykit/src/lib/service/transport-builder/new-tab-transport.builder.ts b/packages/identitykit/src/lib/service/transport-builder/new-tab-transport.builder.ts
@@ -1,11 +1,13 @@
 import { Transport } from "@slide-computer/signer"
 import { PostMessageTransport, PostMessageTransportOptions } from "@slide-computer/signer-web"
 
+export const NEW_TAB_TRANSPORT_DEFAULT_ESTABLISH_TIMEOUT = 60000 // 1 min
+
 export async function getPopupTransportBuilder(
   options: PostMessageTransportOptions
 ): Promise<Transport> {
   return new PostMessageTransport({
     ...options,
-    establishTimeout: 15000,
+    establishTimeout: NEW_TAB_TRANSPORT_DEFAULT_ESTABLISH_TIMEOUT, // 1 min
   })
 }
