WEBDEV-7387 Fix off-by-one years published on result tiles (#453)

* Upgrade to alpha field-parsers & other dependencies

* Fix bug in how Jan 1 midnight dates are recognized

* Correct unit tests

* Undo some overzealous test adjustments

* Undo a couple of unneeded test adjustments

* Upgrade off alpha versions

Author: latonv

package.json

@@ -25,14 +25,14 @@
   "dependencies": {
     "@internetarchive/analytics-manager": "^0.1.4",
     "@internetarchive/feature-feedback": "^0.1.4",
-    "@internetarchive/field-parsers": "^0.1.4",
+    "@internetarchive/field-parsers": "^1.0.0",
     "@internetarchive/histogram-date-range": "^1.2.1",
     "@internetarchive/ia-activity-indicator": "^0.0.6",
     "@internetarchive/ia-dropdown": "^1.3.10",
-    "@internetarchive/iaux-item-metadata": "^1.0.4",
+    "@internetarchive/iaux-item-metadata": "^1.0.5",
     "@internetarchive/infinite-scroller": "^1.0.1",
     "@internetarchive/modal-manager": "^2.0.1",
-    "@internetarchive/search-service": "^2.2.0",
+    "@internetarchive/search-service": "^2.2.1",
     "@internetarchive/shared-resize-observer": "^0.2.0",
     "@lit/localize": "^0.12.2",
     "dompurify": "^3.2.4",

src/utils/local-date-from-utc.ts

@@ -11,5 +11,5 @@ export function localDateFromUTC(date: Date): Date {
  */
 export function isFirstMillisecondOfUTCYear(date?: Date): boolean {
   if (!date) return false;
-  return localDateFromUTC(date).toISOString().endsWith('-01-01T00:00:00.000Z');
+  return date.toISOString().endsWith('-01-01T00:00:00.000Z');
 }

test/tiles/grid/item-tile.test.ts

@@ -247,7 +247,7 @@ describe('Item Tile', () => {
 
   it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<ItemTile>(html`

test/tiles/list/tile-list-compact.test.ts

@@ -161,7 +161,7 @@ describe('List Tile Compact', () => {
 
   it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<TileListCompact>(html`

test/tiles/list/tile-list.test.ts

@@ -216,9 +216,9 @@ describe('List Tile', () => {
     expect(dateRow?.textContent?.trim()).to.contain('Reviewed:  Jan 02, 2013');
   });
 
-  it('should only show the year for a date published of Jan 1 at midnight', async () => {
+  it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<TileList>(html`
@@ -234,7 +234,7 @@ describe('List Tile', () => {
     expect(dateRow?.textContent?.trim()).to.contain('Published:  2012');
   });
 
-  it('should show full date added/archived/reviewed, even on Jan 1 at midnight', async () => {
+  it('should show full date added/archived/reviewed, even on Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
       dateAdded: new Date(2010, 0, 1, 0, 0, 0, 0),
       dateArchived: new Date(2011, 0, 1, 0, 0, 0, 0),

test/utils/local-date-from-utc.test.ts

@@ -16,18 +16,18 @@ describe('localDateFromUTC', () => {
 
 describe('isFirstMillisecondOfUTCYear', () => {
   it('returns true when date is exactly Jan 1 at midnight in UTC', async () => {
-    const midnightOnNewYearsDay = new Date(2010, 0, 1, 0, 0, 0, 0);
+    const midnightOnNewYearsDay = new Date('2010-01-01T00:00:00Z');
     expect(isFirstMillisecondOfUTCYear(midnightOnNewYearsDay)).to.be.true;
   });
 
   it('returns false when date is not exactly Jan 1 at midnight in UTC', async () => {
-    const oneMillisecondTooEarly = new Date(2009, 11, 31, 23, 59, 59, 999);
+    const oneMillisecondTooEarly = new Date('2009-12-31T23:59:59.999Z');
     expect(isFirstMillisecondOfUTCYear(oneMillisecondTooEarly)).to.be.false;
 
-    const oneMillisecondTooLate = new Date(2010, 0, 1, 0, 0, 0, 1);
+    const oneMillisecondTooLate = new Date('2010-01-01T00:00:00.001Z');
     expect(isFirstMillisecondOfUTCYear(oneMillisecondTooLate)).to.be.false;
 
-    const middleOfTheYear = new Date(2010, 6, 1, 0, 0, 0, 0);
+    const middleOfTheYear = new Date('2010-06-01T00:00:00Z');
     expect(isFirstMillisecondOfUTCYear(middleOfTheYear)).to.be.false;
   });
 

yarn.lock

@@ -311,10 +311,10 @@
     "@internetarchive/shared-resize-observer" "^0.2.0"
     lit "^2.2.7"
 
-"@internetarchive/field-parsers@^0.1.4":
-  version "0.1.4"
-  resolved "https://registry.npmjs.org/@internetarchive/field-parsers/-/field-parsers-0.1.4.tgz"
-  integrity sha512-J5nhMsIU91eXnfoApa6SE0PffPbwK1Cd3YTLX/HjgayzMbXVkQvfebfVKSaoPmzHRRttbtY3Sg9FjviCwBq6qg==
+"@internetarchive/field-parsers@^1.0.0":
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/@internetarchive/field-parsers/-/field-parsers-1.0.0.tgz#ee3d3efb280860018193c2c52d54ec784e9bb202"
+  integrity sha512-cbD0FtJOjzBm7exxFrzrkHnqbmalKbEXA4i7KrwhUGBojF/QTTLAvaIRXH/bfoiTyCh6YT1/E/mULAQPdB6yvQ==
 
 "@internetarchive/histogram-date-range@^1.2.1":
   version "1.2.1"
@@ -339,12 +339,12 @@
   dependencies:
     lit "^2.8.0"
 
-"@internetarchive/iaux-item-metadata@^1.0.4":
-  version "1.0.4"
-  resolved "https://registry.npmjs.org/@internetarchive/iaux-item-metadata/-/iaux-item-metadata-1.0.4.tgz"
-  integrity sha512-9md21gRp4MxupvwU6d84HCybW1mK1ihe7H42FTaSlNTYSqZQaOFcYqvvG9QPKjxQj+4wXjbk/ulxz8onEAWiHA==
+"@internetarchive/iaux-item-metadata@^1.0.4", "@internetarchive/iaux-item-metadata@^1.0.5":
+  version "1.0.5"
+  resolved "https://registry.yarnpkg.com/@internetarchive/iaux-item-metadata/-/iaux-item-metadata-1.0.5.tgz#d6854754aced46e12dae4ea89aeb4a14b5643391"
+  integrity sha512-FArosV3Y/x588QjBSrH15mqeWCivh7hGgRGXoSdauuwqRyPjY/FI3VM69Ox92zZ9Qrm8JOTn3dzbHN0WbiiVtg==
   dependencies:
-    "@internetarchive/field-parsers" "^0.1.4"
+    "@internetarchive/field-parsers" "^1.0.0"
     typescript-memoize "^1.1.1"
 
 "@internetarchive/icon-close@^1.3.4":
@@ -407,10 +407,10 @@
   resolved "https://registry.npmjs.org/@internetarchive/result-type/-/result-type-0.0.1.tgz"
   integrity sha512-sWahff5oP1xAK1CwAu1/5GTG2RXsdx/sQKn4SSOWH0r0vU2QoX9kAom/jSXeBsmgK0IjTc+9Ty9407SMORi+nQ==
 
-"@internetarchive/search-service@^2.2.0":
-  version "2.2.0"
-  resolved "https://registry.yarnpkg.com/@internetarchive/search-service/-/search-service-2.2.0.tgz#a4175322f0f7043481ee51af2bb13af5eb22377c"
-  integrity sha512-Gyg9HT5JLdc17Dh4F+Ijl2YFgNIzekPHHAzaNcMbWW9ZNcUU8CnxWra9oHHc9PbJYEL/K8V4Hn3CP3YXPYQSsA==
+"@internetarchive/search-service@^2.2.1":
+  version "2.2.1"
+  resolved "https://registry.yarnpkg.com/@internetarchive/search-service/-/search-service-2.2.1.tgz#bb3339b3ebbbd8b4d5e02166aa90b8309073ff58"
+  integrity sha512-MNwlgvC5M6XNMq/7fuK6Wvg3oF7tJLGwWhEovJeZSmNSwaiL/tYHMofNuCYiGcSpZq4vENcqQRnJ6xgk3mkpqg==
   dependencies:
     "@internetarchive/iaux-item-metadata" "^1.0.4"
     "@internetarchive/result-type" "^0.0.1"