From 0ba77c3966ae50d47e40a6310bf8eced16c99ecc Mon Sep 17 00:00:00 2001
From: chaw <cshen_581@hotmail.com>
Date: Thu, 11 May 2023 07:42:51 +0800
Subject: [PATCH 1/2] [AV2-1380] empty tasks handling

---
 projects/v3/src/app/services/activity.service.ts | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/projects/v3/src/app/services/activity.service.ts b/projects/v3/src/app/services/activity.service.ts
index e68208b33..da94f31bd 100644
--- a/projects/v3/src/app/services/activity.service.ts
+++ b/projects/v3/src/app/services/activity.service.ts
@@ -209,6 +209,11 @@ export class ActivityService {
     if (!tasks) {
       tasks = this.activity.tasks;
     }
+
+    if (this.utils.isEmpty(tasks) || tasks.length === 0) {
+      tasks = [];
+    }
+
     // find the first task that is not done or pending review
     // and is allowed to access for this user
     let skipTask = !!afterTask;
@@ -245,13 +250,16 @@ export class ActivityService {
     }
 
     // if there is no next task
-    if (!nextTask) {
+    if (this.utils.isEmpty(nextTask)) {
       if (afterTask) {
         return this._activityCompleted(hasUnfinishedTask);
       }
       nextTask = tasks[0];
     }
-    this.goToTask(nextTask);
+
+    if (!this.utils.isEmpty(nextTask)) {
+      return this.goToTask(nextTask);
+    }
   }
 
   private _activityCompleted(showPopup: boolean) {

From 765877066abe0b40c048d50d91bd87b5c9a286b6 Mon Sep 17 00:00:00 2001
From: chaw <cshen_581@hotmail.com>
Date: Thu, 11 May 2023 08:08:54 +0800
Subject: [PATCH 2/2] [AV2-1380] "no tasks" indicator

---
 .../activity/activity.component.html           | 18 ++++++++++++++++--
 .../v3/src/app/services/activity.service.ts    |  4 ++--
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/projects/v3/src/app/components/activity/activity.component.html b/projects/v3/src/app/components/activity/activity.component.html
index efa3d4ca5..78edd78c1 100644
--- a/projects/v3/src/app/components/activity/activity.component.html
+++ b/projects/v3/src/app/components/activity/activity.component.html
@@ -3,7 +3,7 @@
     <h1 id="activity-name" *ngIf="activity.name" class="headline-2 activity-name">
       {{ activity.name }}
     </h1>
-    <ion-skeleton-text *ngIf="!activity.name" animated style="width: 50%;" aria-hidden="true"></ion-skeleton-text>
+    <ion-skeleton-text *ngIf="!activity.tasks" animated style="width: 50%;" aria-hidden="true"></ion-skeleton-text>
 
     <div class="task-count">
       <ion-text *ngIf="activity.tasks" class="subtitle-3" color="grey-75" i18n>
@@ -20,7 +20,10 @@ <h1 id="activity-name" *ngIf="activity.name" class="headline-2 activity-name">
 
   <ion-item class="headline-4 task-header" lines="none" i18n>{activity.tasks.length, plural, =1 {Task} other {Tasks}}</ion-item>
 
-  <app-list-item class="focusable"
+  <ng-container *ngTemplateOutlet="noTasks"></ng-container>
+
+  <app-list-item
+    class="focusable"
     role="button"
     tabindex="0"
     *ngFor="let task of (activity?.tasks || []); let i = index"
@@ -49,3 +52,14 @@ <h1 id="activity-name" *ngIf="activity.name" class="headline-2 activity-name">
     <ion-skeleton-text animated style="width: 90%"></ion-skeleton-text>
   </div>
 </ng-template>
+
+<ng-template #noTasks>
+  <div *ngIf="activity?.tasks?.length === 0" class="ion-padding" aria-live="polite" aria-label="no tasks available">
+    <app-list-item
+      lines="none"
+      subtitle1Color="grey-50"
+      title="No tasks available."
+      i18n-title
+      ></app-list-item>
+  </div>
+</ng-template>
diff --git a/projects/v3/src/app/services/activity.service.ts b/projects/v3/src/app/services/activity.service.ts
index da94f31bd..c30a0d70f 100644
--- a/projects/v3/src/app/services/activity.service.ts
+++ b/projects/v3/src/app/services/activity.service.ts
@@ -126,9 +126,9 @@ export class ActivityService {
     }
     return this.getActivityBase(id).pipe(
       map(res => this._normaliseActivity(res.data, goToNextTask, afterTask))
-    ).subscribe(_res => {
+    ).subscribe(res => {
       if (callback instanceof Function) {
-        return callback(_res);
+        return callback(res);
       }
       return;
     });