Merge pull request #1 from adierkens/remove-child

Support removing children

Author: adierkens

package.json

@@ -18,8 +18,8 @@
     "prepare": "is-ci || husky install"
   },
   "files": [
-    "src",
-    "dist",
+    "src/",
+    "dist/",
     "logo.png"
   ],
   "devDependencies": {

src/__tests__/render.test.tsx

@@ -114,4 +114,25 @@ describe("refs", () => {
     expect.assertions(2);
     expect(await render(element)).toStrictEqual("Foo");
   });
+
+  it("removes items from a container", async () => {
+    const Custom = () => {
+      const [show, setShow] = React.useState(false);
+
+      React.useEffect(() => {
+        setShow(true);
+      }, [show]);
+
+      return (
+        <array>
+          <value>1</value>
+          {show && <value>2</value>}
+        </array>
+      );
+    };
+
+    const element = <Custom />;
+
+    expect(await render(element)).toStrictEqual(["1", "2"]);
+  });
 });

src/host-config.ts

@@ -85,6 +85,32 @@ function createInstance<T extends keyof JsonElements>(
   }
 }
 
+/** remove a child from the node */
+function removeChild(parent: JsonNode, child: JsonNode) {
+  switch (parent.type) {
+    case "array":
+      parent.items = parent.items.filter((c) => c !== child);
+      break;
+
+    case "object":
+      parent.properties = parent.properties.filter((c) => c !== child);
+      break;
+
+    case "property":
+      if (parent.valueNode === child) {
+        parent.valueNode = undefined;
+      }
+
+      break;
+    case "value":
+      parent.items = parent.items.filter((c) => c !== child) as any;
+
+      break;
+    default:
+      throw new Error("Unknown type");
+  }
+}
+
 export const hostConfig: HostConfig<
   keyof JsonElements,
   any,
@@ -119,7 +145,8 @@ export const hostConfig: HostConfig<
   },
 
   clearContainer: (parent: JsonNode) => {},
-
+  removeChildFromContainer: removeChild,
+  removeChild,
   finalizeInitialChildren: () => false,
   prepareUpdate: () => null,
   shouldSetTextContent: () => false,