Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runs: Implement custom run stop logic #19

Open
yashlamba opened this issue May 28, 2024 · 0 comments
Open

runs: Implement custom run stop logic #19

yashlamba opened this issue May 28, 2024 · 0 comments

Comments

@yashlamba
Copy link
Member

In the current implementation #16, we are doing celery revoke and terminate task for cancelling a run. This is ok but doesn't give us much control over cleanup and saving the progress of a task.

A custom implementation would (might) include:

  • Have separate states (canceling/cancelled, stopping/stopped etc), one is updated when the stop is requested and the other for when it is actually stopped.
  • Do the check in the task whether the run was requested to be stopped and do the cleanup as required.

This gives us more control over how to stop and do other transitions like pause in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant