Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPES must be in own file!? #1455

Open
andrecadete opened this issue May 9, 2022 · 2 comments
Open

TYPES must be in own file!? #1455

andrecadete opened this issue May 9, 2022 · 2 comments

Comments

@andrecadete
Copy link

Hi, not really a bug report, just to see if you are aware since this is not obvious in the docs. As title states.

In fact I cannot get this to work unless the TYPES are explicitly declared and exported in their own file. For example, if the TYPES are exported and declared in the same file as the Container extension class, we will get something: "TypeError: Cannot read property 'DynamoDB' of undefined", where undefined are our TYPES.

Please let me know if this is expected behavior and if so I'll open a PR to improve the docs' clarity in that sense.

Thanks

@AkshayJangid
Copy link
Contributor

Hey, I'll be more then happy to make a PR for this. Let me know if i can help here, but lets add this ASAP.

@Jameskmonger Jameskmonger mentioned this issue Nov 1, 2023
9 tasks
Jameskmonger added a commit that referenced this issue Nov 2, 2023
* Update README.md

by going through the documentation , it is not where hinted that we need to place it in separate file. Thus explicitly mentioning it in readme.

* Update README.md

add link to bug

---------

Co-authored-by: James Monger <[email protected]>
@shellscape
Copy link

@Jameskmonger given your comments here #1546 (comment), this is probably worthy of a look given its age, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants