-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove browser
test suite
#1536
Comments
Inviting feedback on this for the next few days, in the absence of any feedback I will be removing the faulty pipeline to unblock PR #1531 cc @inversify/maintainers @inversify/collaborators @PodaruDragos @dcavanagh |
+1 from me. If we ever need browser tests, we can always just use a different maintained framework like puppeteer. |
+1 For context when the browser tests were added was a time in which we still had IE and browser compatibility was still a very big issue. I don't think is relevant today. |
+1 from me, no argument here |
Thanks for the feedback @PodaruDragos @remojansen @acald-creator I will get on this this morning 😄 |
closes #1536, see there for reasoning + discussion
closes #1536, see there for reasoning + discussion
closes #1536, see there for reasoning + discussion
The
browser
test suite is no longer functionalPhantomJS has not been supported since 2018 so I suggest we remove this test suite.
I'm not convinced there's much value in a specific set of browser tests anyway, given that our bundling mechanisms aren't necessarily the same as our users'.
The text was updated successfully, but these errors were encountered: