Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow to use constructor injections in middlewares for scoped to http dependencies #2

Merged

Conversation

b1ff
Copy link

@b1ff b1ff commented Nov 18, 2021

Description

Closes https://github.com/inversify/InversifyJS/issues/1220

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ndencies in middlewares. Fixed a bunch of tests for base middlewares since before they were always green due to missed correct async flow in tests.
@b1ff b1ff changed the title Feature/allow to use constructor injections in middlewares Feature/allow to use constructor injections in middlewares for scoped to http dependencies Nov 18, 2021
@b1ff b1ff merged commit 1714f9d into master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inversify-express-utils] allow to inject dependencies into middleware constructor
2 participants