Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vuepress #17

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Migrate to Vuepress #17

wants to merge 14 commits into from

Conversation

leonardssh
Copy link
Member

@leonardssh leonardssh commented May 6, 2021

Closes #16

Live Preview: https://inversify.leonard.sh/

  • Testimonies
  • Ecosystem
  • Support

@leonardssh leonardssh requested a review from a team May 6, 2021 20:48
@leonardssh leonardssh marked this pull request as draft May 6, 2021 21:17
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I requested some changes. We should probably think how to control the internationalization coverage.

CNAME Show resolved Hide resolved
ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
src/.vuepress/theme/components/NavLinks.vue Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@leonardssh
Copy link
Member Author

updated preview link.

@leonardssh leonardssh marked this pull request as ready for review May 7, 2021 14:54
@PodaruDragos
Copy link
Member

hey @leonardssh @dcavanagh @notaphplover do we not want to merge this ?
I remember the preview looked great

@leonardssh
Copy link
Member Author

@PodaruDragos I need to take a little look at what I did last time, I know there were little problems, maybe I'll replace Vuepress with Vitepress. I also need to get in touch with whoever now owns the actual deployment for the website, so I know what to do.

@leonardssh leonardssh marked this pull request as draft January 27, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Vuepress
3 participants