refactor(crashlytics): migrate to TypeScript. (#8814)

Author: russellwheatley

packages/analytics/lib/namespaced.ts

@@ -116,7 +116,7 @@ const ReservedEventNames: readonly string[] = [
   'user_engagement',
 ] as const;
 
-const statics: Statics = {};
+const statics: Partial<Statics> = {};
 
 const namespace = 'analytics';
 

packages/analytics/lib/types/analytics.ts

@@ -713,8 +713,9 @@ export interface EventParams {
 //   search_term: string;
 // }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-object-type
-export interface Statics {}
+export interface Statics {
+  SDK_VERSION: string;
+}
 
 /**
  * Analytics instance initialization options. Web only.

packages/analytics/tsconfig.json

@@ -1,25 +1,6 @@
 {
+  "extends": "../../tsconfig.packages.base.json",
   "compilerOptions": {
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx",
-    "lib": ["ESNext"],
-    "module": "ESNext",
-    "moduleResolution": "bundler",
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noStrictGenericChecks": false,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "target": "ESNext",
-    "verbatimModuleSyntax": true,
     "baseUrl": ".",
     "rootDir": ".",
     "paths": {

packages/app/lib/internal/index.ts

@@ -25,3 +25,4 @@ export * from './registry/namespace';
 export * from './registry/nativeModule';
 export { default as SharedEventEmitter } from './SharedEventEmitter';
 export { Logger } from './logger';
+export type { ModuleConfig } from '../types/internal';

packages/app/tsconfig.json

@@ -1,27 +1,9 @@
 {
+  "extends": "../../tsconfig.packages.base.json",
   "compilerOptions": {
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx",
-    "lib": ["ESNext", "DOM"],
-    "module": "ESNext",
-    "moduleResolution": "bundler",
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noStrictGenericChecks": false,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "target": "ESNext",
-    "verbatimModuleSyntax": true,
     "baseUrl": ".",
-    "rootDir": "."
+    "rootDir": ".",
+    "lib": ["ESNext", "DOM"]
   },
   "include": ["lib/**/*"],
   "exclude": ["node_modules", "dist", "__tests__", "**/*.test.ts"]

packages/crashlytics/lib/handlers.js packages/crashlytics/lib/handlers.tspackages/crashlytics/lib/handlers.js renamed to packages/crashlytics/lib/handlers.ts

@@ -15,20 +15,48 @@
  *
  */
 
-import { firebase } from '@react-native-firebase/app';
+import { firebase } from '.';
 import { isError, once } from '@react-native-firebase/app/lib/common';
+// @ts-ignore - No declaration file for promise/setimmediate/rejection-tracking
 import tracking from 'promise/setimmediate/rejection-tracking';
 import StackTrace from 'stacktrace-js';
-
 export const FATAL_FLAG = 'com.firebase.crashlytics.reactnative.fatal';
 
-export function createNativeErrorObj(error, stackFrames, isUnhandledRejection, jsErrorName) {
-  const nativeObj = {};
+interface NativeErrorFrame {
+  src: string;
+  line: number;
+  col: number;
+  fn: string;
+  file: string;
+}
+
+interface NativeErrorObj {
+  message: string;
+  isUnhandledRejection: boolean;
+  frames: NativeErrorFrame[];
+}
 
-  nativeObj.message = `${error.message}`;
-  nativeObj.isUnhandledRejection = isUnhandledRejection;
+interface NativeModule {
+  isCrashlyticsCollectionEnabled: boolean;
+  isErrorGenerationOnJSCrashEnabled: boolean;
+  isCrashlyticsJavascriptExceptionHandlerChainingEnabled: boolean;
+  logPromise(message: string): Promise<void>;
+  setAttribute(name: string, value: string): Promise<void>;
+  recordErrorPromise(errorObj: NativeErrorObj): Promise<void>;
+  crashWithStackPromise(errorObj: NativeErrorObj): Promise<void>;
+}
 
-  nativeObj.frames = [];
+export function createNativeErrorObj(
+  error: Error,
+  stackFrames: StackTrace.StackFrame[],
+  isUnhandledRejection: boolean,
+  jsErrorName?: string,
+): NativeErrorObj {
+  const nativeObj: NativeErrorObj = {
+    message: `${error.message}`,
+    isUnhandledRejection,
+    frames: [],
+  };
 
   if (jsErrorName) {
     // Option to fix crashlytics display and alerting. You can add an error name to the recordError function
@@ -42,7 +70,10 @@ export function createNativeErrorObj(error, stackFrames, isUnhandledRejection, j
   }
 
   for (let i = 0; i < stackFrames.length; i++) {
-    const { columnNumber, lineNumber, fileName, functionName, source } = stackFrames[i];
+    const frame = stackFrames[i];
+    if (!frame) continue;
+
+    const { columnNumber, lineNumber, fileName, functionName, source } = frame;
     let fileNameParsed = '<unknown>';
     if (fileName) {
       const subStrLen = fileName.indexOf('?');
@@ -54,7 +85,7 @@ export function createNativeErrorObj(error, stackFrames, isUnhandledRejection, j
     }
 
     nativeObj.frames.push({
-      src: source,
+      src: source || '<unknown>',
       line: lineNumber || 0,
       col: columnNumber || 0,
       fn: functionName || '<unknown>',
@@ -65,10 +96,10 @@ export function createNativeErrorObj(error, stackFrames, isUnhandledRejection, j
   return nativeObj;
 }
 
-export const setGlobalErrorHandler = once(nativeModule => {
+export const setGlobalErrorHandler = once((nativeModule: NativeModule) => {
   const originalHandler = ErrorUtils.getGlobalHandler();
 
-  async function handler(error, fatal) {
+  async function handler(error: unknown, fatal?: boolean) {
     // If collection is disabled, just forward to the original handler
     if (!nativeModule.isCrashlyticsCollectionEnabled) {
       return originalHandler(error, fatal);
@@ -89,7 +120,7 @@ export const setGlobalErrorHandler = once(nativeModule => {
         // For that reason we always round up (`.ceil`) and add a second in case of latency
         //
         // Time is specified as seconds since start of Unix epoch as a baseline, as a string
-        const fatalTime = Math.ceil(new Date() / 1000) + 1 + '';
+        const fatalTime = Math.ceil(new Date().getTime() / 1000) + 1 + '';
 
         // Flag the Crashlytics backend that we have a fatal error, they will transform it
         await nativeModule.setAttribute(FATAL_FLAG, fatalTime);
@@ -107,6 +138,7 @@ export const setGlobalErrorHandler = once(nativeModule => {
           // Did not matter if I did named imports above or dynamic require here.
           // So temporarily reverting and silencing warnings instead
           globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+          // @ts-ignore - analytics types not available in crashlytics
           await firebase.app().analytics().logEvent(
             'app_exception', // 'app_exception' is reserved but we make an exception for JS->fatal transforms
             {
@@ -143,8 +175,8 @@ export const setGlobalErrorHandler = once(nativeModule => {
   return handler;
 });
 
-export const setOnUnhandledPromiseRejectionHandler = once(nativeModule => {
-  async function onUnhandled(_id, error) {
+export const setOnUnhandledPromiseRejectionHandler = once((nativeModule: NativeModule) => {
+  async function onUnhandled(_id: number, error: Error) {
     if (!__DEV__) {
       // TODO(salakar): Option to disable
       try {