Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Refactor HotKeys Implementation #3959

Open
1 task done
Millu opened this issue Jul 24, 2023 · 2 comments
Open
1 task done

[enhancement]: Refactor HotKeys Implementation #3959

Millu opened this issue Jul 24, 2023 · 2 comments
Labels
enhancement New feature or request web ui

Comments

@Millu
Copy link
Contributor

Millu commented Jul 24, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Contact Details

No response

What should this feature add?

Hotkeys registered all over the app and they often conflict, or do two things for one hotkey

The solution is to use the react-hotkeys-hook’s scoping features to change the hotkey scope depending on where you are in the app, and enable hotkeys based on this.

Discussion notes:

We also want to centralize the key combos & associated actions and make them user-editable.

This would be implemented in stages:

  1. Store the hotkey data in memory (e.g. just a constant)
  2. Implement editing
    a. Persist the hotkeys to localStorage
    b. Allow editing of the hotkeys
  3. Implement backend permanent storage (?)
  • Are hotkeys server state or client state? I think server state, so they need to be stored in the backend, but this is open to dissenting opinions
  • Needs backend storage mechanism - JSON or db?
  • Needs API routes

Alternatives

No response

Aditional Content

No response

@Millu Millu added the enhancement New feature or request label Jul 24, 2023
@KevinBrack
Copy link
Contributor

Can you assign this to me, please?

@psychedelicious
Copy link
Collaborator

The react-hotkeys-hook library has a number of issues. It's not clear if it is capable enough for our needs. It looks like a theoretical v5 will improve things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web ui
Projects
None yet
Development

No branches or pull requests

3 participants