Skip to content
This repository was archived by the owner on May 21, 2020. It is now read-only.
This repository was archived by the owner on May 21, 2020. It is now read-only.

Suggestions #1

@felipeZ

Description

@felipeZ

I have some suggestion that you are very welcome to ignore if don't find them useful ;) BTW, It is really well documented 👍

  • Reduce parameters. If a class, method or functions take more than five parameters and most of the parameters have a reasonable default, it is better to encapsulate those parameters into a class or dictionary. Those classes and dictionaries can stored the default values in JSON or YAML files. Also, from Python 3.8 onwards you can you data classes
  • Remove deeply nested statements. There are some deeply nested statements like this that make the code really difficult to read. As stated above, those can be replaced by data classes and/or dictionaries.

..to be continued

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions