Skip to content

Commit ba5f8f2

Browse files
committed
Force number parse for versionCode and buildNumber. #165 #164
1 parent 56ded7e commit ba5f8f2

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/project/src/android/project.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ export class AndroidProject extends PlatformProject {
275275
versionCode = 1;
276276
}
277277

278-
return this.appBuildGradle?.setVersionCode(typeof versionCode === 'number' ? versionCode : 1);
278+
return this.appBuildGradle?.setVersionCode(typeof versionCode === 'number' ? versionCode : parseInt(versionCode, 10));
279279
}
280280

281281
async getVersionCode(): Promise<number | null> {

packages/project/src/ios/project.ts

+2
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,8 @@ export class IosProject extends PlatformProject {
200200
// This shouldn't happen but can
201201
buildNumber = 1;
202202
this.pbxProject?.updateBuildProperty('CURRENT_PROJECT_VERSION', 1, buildName, targetName);
203+
} else if (typeof buildNumber === 'string') {
204+
buildNumber = parseInt(buildNumber, 10);
203205
}
204206

205207
this.pbxProject?.updateBuildProperty('CURRENT_PROJECT_VERSION', buildNumber ?? 1, buildName, targetName);

0 commit comments

Comments
 (0)