Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Werror=undef when compiling bcc to catch issues when a macro is not defined. #5019

Closed
chantra opened this issue May 29, 2024 · 1 comment · Fixed by #5088 · May be fixed by #5089
Closed

Use -Werror=undef when compiling bcc to catch issues when a macro is not defined. #5019

chantra opened this issue May 29, 2024 · 1 comment · Fixed by #5088 · May be fixed by #5089

Comments

@chantra
Copy link
Contributor

chantra commented May 29, 2024

A macro which is not defined will default to 0, this can make it challenging to debug issues as the compiler will happily go ahead and treat an undefined macro to 0.

Here is an example case where it caught an issue: bpftrace/bpftrace@a0eefb6
@chantra
Copy link
Contributor Author

chantra commented May 29, 2024

cc @yonghong-song as we were discussing this f2f.

This was referenced Aug 24, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libbpf-tools: Use -Werror=undef ShawnZhong/bcc
bcc: Use -Werror=undef ShawnZhong/bcc
1 participant
@chantra