Bump min Python version from 3.5.4 to 3.6.2

Author: c0llab0rat0r

.travis.yml

@@ -5,7 +5,6 @@ dist: bionic  # VirtualEnv is too old on xenial
 
 matrix:
    include:
-      - python: "3.5"
       - python: "3.6"
       - python: "3.7"
       - python: "3.8"
@@ -23,9 +22,6 @@ matrix:
 
       # Testing on macOS/Darwin tends to be much slower so only test the bare minimum
       #
-      # Minimum testing version is 3.6, since the 3.5 binaries from python.org fail
-      # with TLS error when trying to install `tox`.
-      #
       # When changing any version here also update the relevant checksum below with
       # the values found on the https://python.org/ website.
       - os: osx

ipfshttpclient/client/base.py

@@ -9,11 +9,14 @@
 from .. import multipart, http, utils
 
 
+#XXX: Review if this is still necessary after requiring Python 3.8.
 if ty.TYPE_CHECKING:
 	import typing_extensions as ty_ext
 else:
 	ty_ext = utils
 
+# Ensure that proper types show up when generating documentation without hard-depending on
+# the cid package.
 if "cid" in sys.modules:
 	import cid  # type: ignore[import]
 	cid_t = ty.Union[str, cid.CIDv0, cid.CIDv1]
@@ -29,7 +32,7 @@
 json_primitive_t = utils.json_primitive_t
 json_value_t = utils.json_value_t
 
-# The following would be much more useful once GH/python/mypy#4441 is implemented…
+#XXX: The following would be more useful with https://github.com/python/mypy/issues/4441
 if ty.TYPE_CHECKING:
 	# Lame workaround for type checkers
 	CommonArgs = ty.Union[bool, http.auth_t, http.cookies_t, http.reqdata_sync_t,
@@ -48,7 +51,7 @@
 else:
 	CommonArgs = ty.Dict[str, ty.Any]
 
-# work around GH/mypy/mypy#731: no recursive structural types yet
+#XXX: work around https://github.com/python/mypy/issues/731: no recursive structural types yet
 response_item_t = ty.Union[
 	json_primitive_t,
 	"ResponseBase",

ipfshttpclient/exceptions.py

@@ -1,5 +1,5 @@
 """
-The class hierachy for exceptions is::
+The class hierarchy for exceptions is:
 
 	Error
 	 ├── VersionMismatch
@@ -161,4 +161,4 @@ class ConnectionError(CommunicationError):
 
 class TimeoutError(CommunicationError):
 	"""Raised when the daemon didn't respond in time."""
-	__slots__ = ()
+	__slots__ = ()