Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 is past EOL; Drop Support #258

Closed
c0llab0rat0r opened this issue Apr 4, 2021 · 3 comments
Closed

Python 3.5 is past EOL; Drop Support #258

c0llab0rat0r opened this issue Apr 4, 2021 · 3 comments

Comments

@c0llab0rat0r
Copy link
Contributor

Drop support for Python 3.5 by raising the minimum version to 3.6 (EOL this year) or 3.7 (EOL 2023).

This will make fixing the typing and type linting easier.

The code base currently has syntax that is not valid in 3.5, such as this at https://github.com/ipfs-shipyard/py-ipfs-http-client/blob/0.7.0/ipfshttpclient/http_httpx.py#L41

def map_args_to_httpx(
    *,
    auth: auth_t = None,
    cookies: cookies_t = None,
    headers: headers_t = None,
    params: params_t = None,
    timeout: timeout_t = None,
) -> RequestArgs:
@c0llab0rat0r
Copy link
Contributor Author

If #260 is merged, it would resolve this issue.

@ntninja
Copy link
Contributor

ntninja commented Apr 5, 2021

The post-EOL compatibility with Python 3.5 is intentional since this project pledged support for Ubuntu 16.04LTS for servers. That will be EOL the end of this month, so dropping 3.5 is OK. Support for 3.6 is still necessary – in general this library does intend to be appealing to a large audience, so premature deprecation is a no-go.

The quoted piece of source code is not used in Python 3.5 btw, so it's lot like “Python 3.5 is already broken anyways” (this part of CI is still functional).

@ntninja
Copy link
Contributor

ntninja commented Apr 9, 2021

This you have fixed as well now!

@ntninja ntninja closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants