Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT] Implement host/serialized encoding interface for GPUEncodingLayoutAttr #20021

Open
hanhanW opened this issue Feb 18, 2025 · 1 comment
Open
Assignees

Comments

@hanhanW
Copy link
Contributor

hanhanW commented Feb 18, 2025

The CPU and VMVX attributes finished most of the implementation for encoding specialization. The remaining task is adding an e2e test, and I'm working on it.

On GPU side, the path is still experimental, so I did not add the support yet. We are missing the implementation for EncodingLayoutAttrInterface and SerializedEncodingLayoutAttrInterface.

In the data-tiling, we have MaterializeEncodingInfo struct to describe the layouts. Different from CPU backends, GPU has "swizzle". This field can be ignored in the interface implementation because it describes the layout of inner tiles, while it does not impact any storage size calculation. Thus, the implementation would be very similar to CPU attributes.

Here is one of examples that what is implemented for CPU backends: #19686

For more information, please take a look at https://hackmd.io/@hwPnnvLBTB-JGVMeh-bCEA/r1dLRr1Fyl. The last section has the demo of how it works in CPU and GPU.

@hanhanW hanhanW changed the title Implement host/serialized encoding interface for GPUEncodingLayoutAttr [DT] Implement host/serialized encoding interface for GPUEncodingLayoutAttr Feb 18, 2025
@jtuyls
Copy link
Contributor

jtuyls commented Feb 19, 2025

@hanhanW I tried implementing the EncodingLayoutAttrInterface in #20027. Could you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants