Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to codemirror 3.0 #22

Open
iros opened this issue Dec 21, 2012 · 1 comment
Open

Upgrade to codemirror 3.0 #22

iros opened this issue Dec 21, 2012 · 1 comment
Assignees

Comments

@iros
Copy link
Owner

iros commented Dec 21, 2012

No description provided.

@ghost ghost assigned iros Dec 21, 2012
@marijnh
Copy link

marijnh commented Feb 7, 2013

I just spent some time looking into a hang 1 that was caused by accidentally using CM3 with deck.js-codemirror. The main problem seems to be that deck.js has some overreaching css rules, such as killing the margins and paddings on everything within .deck-container, using a rule that is more specific than a direct class rule, so overriding CodeMirror's css rules, even when they are included after the deck.js css files.

I'm not really keen on adding !important to all the rules in codemirror.css, especially since that'd make it a pain for others to work with, but you may have to deliver a version of codemirror.css that does just that with deck.js-codemirror (or convince the deck.js maintainers to get their css act straight).

Beyond that, I think the only thing you'll have to for this upgrade is to move the sizing css rules to .CodeMirror (not .CodeMirror-scroll), and maybe a few other minor css tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants