Change logging buffer to stderr. Same default as python builtin logging library.

- Changing order of astromodels import in init. It was using astromodels' setup_logger, not threeml's setup_logger
- This revealed a circular import. I patched it with a local import and added a FIXME not about it.

Author: israelmcmc

threeML/__init__.py

@@ -21,11 +21,11 @@
 
 from pathlib import Path
 
-from threeML.io.logging import setup_logger
-
 # Import everything from astromodels
 from astromodels import *
 
+from .io.logging import setup_logger
+
 from .config import (
     threeML_config,
     show_configuration,

threeML/config/config_utils.py

@@ -5,13 +5,15 @@
 from omegaconf import OmegaConf
 from omegaconf.dictconfig import DictConfig
 from rich.tree import Tree
-from threeML.io.logging import setup_logger
 from threeML.io.package_data import get_path_of_user_config
 
 from .config import threeML_config
 
-log = setup_logger(__name__)
-
+# FIXME: These lines were moved to local imports withing functions since
+#  they were causing a circular import. The config module needs the logging setup,
+#  and the logging setup needs the config module.
+#from threeML.io.logging import setup_logger
+#log = setup_logger(__name__)
 
 def recurse_dict(d, tree):
 
@@ -64,6 +66,8 @@ def show_configuration(sub_menu: Optional[str] = None):
 
             msg = f"{sub_menu} is not in the threeml configuration"
 
+            from threeML.io.logging import setup_logger
+            log = setup_logger(__name__)
             log.error(msg)
 
             raise AssertionError(msg)
@@ -111,6 +115,10 @@ def get_value(name, user_value, par_type, config_value):
     :param config_value: value in config
     :returns: parameter value
     """
+
+    from threeML.io.logging import setup_logger
+    log = setup_logger(__name__)
+
     if user_value is not None:
         value = user_value
     else:

threeML/io/logging.py

@@ -118,7 +118,7 @@ def get_path_of_log_file(log_file: str) -> Path:
 # mytheme = Theme().read(_get_data_file_path("log_theme.ini"))
 mytheme = Theme(_theme)
 
-console = Console(theme=mytheme)
+console = Console(theme=mytheme, stderr=True)
 
 
 threeML_console_log_handler = RichHandler(