optee-teec: fix bugs of ParamTypes::into_flags

ivila · ivila · commit 3da0b34698a3 · 2026-06-25T18:50:31.000+08:00
diff --git a/crates/optee-teec/src/parameter.rs b/crates/optee-teec/src/parameter.rs
@@ -241,10 +241,10 @@ impl ParamTypes {
 
     pub fn into_flags(&self) -> (ParamType, ParamType, ParamType, ParamType) {
         (
-            (0x000fu32 & self.0).into(),
-            (0x00f0u32 & self.0).into(),
-            (0x0f00u32 & self.0).into(),
-            (0xf000u32 & self.0).into(),
+            (0x000f_u32 & self.0).into(),
+            ((0x00f0_u32 & self.0) >> 4).into(),
+            ((0x0f00_u32 & self.0) >> 8).into(),
+            ((0xf000_u32 & self.0) >> 12).into(),
         )
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -241,10 +241,10 @@ impl ParamTypes {`
`241`	`241`
`242`	`242`	`pub fn into_flags(&self) -> (ParamType, ParamType, ParamType, ParamType) {`
`243`	`243`	`(`
`244`		`- (0x000fu32 & self.0).into(),`
`245`		`- (0x00f0u32 & self.0).into(),`
`246`		`- (0x0f00u32 & self.0).into(),`
`247`		`- (0xf000u32 & self.0).into(),`
	`244`	`+ (0x000f_u32 & self.0).into(),`
	`245`	`+ ((0x00f0_u32 & self.0) >> 4).into(),`
	`246`	`+ ((0x0f00_u32 & self.0) >> 8).into(),`
	`247`	`+ ((0xf000_u32 & self.0) >> 12).into(),`
`248`	`248`	`)`
`249`	`249`	`}`
`250`	`250`	`}`