Moved class resolution from an eval to a const_get enabling global traits/smarts.

Author: jamesladd

lib/example.rb

@@ -11,23 +11,27 @@ def read(source)
   end
 end
 
-class ExampleStringWriter < Writer
-  def initialize(target)
-  end
-  def start
-  end
-  def finish
-    'Example'  # this isnt a proper Writer implementation, just an Example.
+class Example
+  class StringWriter < Writer
+    def initialize(target)
+    end
+    def start
+    end
+    def finish
+      'Example'  # this isnt a proper Writer implementation, just an Example.
+    end
   end
 end
 
-class ExampleStringReader < Reader
-  def initialize(source)
-  end
-  def start
-  end
-  def finish
-    Example.new # this isnt a proper Reader implementation, just an Example.
+class Example
+  class StringReader < Reader
+    def initialize(source)
+    end
+    def start
+    end
+    def finish
+      Example.new # this isnt a proper Reader implementation, just an Example.
+    end
   end
 end
 
@@ -37,13 +41,15 @@ def print(source)
   end
 end
 
-class ExampleStringPrinter < Printer
-  def initialize(source)
-  end
-  def start
-  end
-  def finish
-    'an Example' # this isnt a proper Printer implementation, just an Example.
+class Example
+  class StringPrinter < Printer
+    def initialize(source)
+    end
+    def start
+    end
+    def finish
+      'an Example' # this isnt a proper Printer implementation, just an Example.
+    end
   end
 end
 
@@ -53,12 +59,14 @@ def convert(source)
   end
 end
 
-class ExampleStringConverter < Converter
-  def initialize(source)
-  end
-  def start
-  end
-  def finish
-    'an Example' # this isnt a proper Converter implementation, just an Example.
+class Example
+  class StringConverter < Converter
+    def initialize(source)
+    end
+    def start
+    end
+    def finish
+      'an Example' # this isnt a proper Converter implementation, just an Example.
+    end
   end
 end

lib/smarts/persistence.rb

@@ -7,8 +7,8 @@ module Writing
     include Support
 
     def store_on(target)
-      writer_class_name = name_for(:writing, self.class, target)
-      writer_class = eval(writer_class_name)
+      writer_class_name = name_for(:writing, target)
+      writer_class = resolve_for(writer_class_name, self.class)
       writer = writer_class.new(target)
       with(writer, :write)
     end
@@ -20,8 +20,8 @@ module Reading
     include Support
 
     def from(source)
-      reader_class_name = name_for(:reading, self, source)
-      reader_class = eval(reader_class_name)
+      reader_class_name = name_for(:reading, source)
+      reader_class = resolve_for(reader_class_name, self)
       reader = reader_class.new(source)
       with(reader, :read)
     end

lib/smarts/representation.rb

@@ -7,8 +7,8 @@ module Printing
     include Support
 
     def print_on(target)
-      printer_class_name = name_for(:printing, self.class, target)
-      printer_class = eval(printer_class_name)
+      printer_class_name = name_for(:printing, target)
+      printer_class = resolve_for(printer_class_name, self.class)
       printer = printer_class.new(target)
       with(printer, :print)
     end

lib/smarts/support.rb

@@ -2,8 +2,12 @@ module Support
 
   private
 
-  def name_for(action, source, target)
-    "::#{source.name}#{target.class.name}#{to_verb(action)}"
+  def name_for(action, target)
+    "#{target.class.name}#{to_verb(action)}"
+  end
+
+  def resolve_for(aClassName, aClass)
+    Module.const_get(aClass.name).const_get(aClassName)
   end
 
   def to_verb(action)

lib/smarts/transformation.rb

@@ -7,8 +7,8 @@ module Converting
     include Support
 
     def convert_to(target)
-      converter_class_name = name_for(:converting, self.class, target)
-      converter_class = eval(converter_class_name)
+      converter_class_name = name_for(:converting, target)
+      converter_class = resolve_for(converter_class_name, self.class)
       converter = converter_class.new(target)
       with(converter, :convert)
     end