tests should all now be running, and breaking records is now O(n) rather than O(n^2)

Author: jamiecurle

test/testutils.py

@@ -18,7 +18,8 @@ class TestCase(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
         """Get all the matching test case files"""
-        cls.tcs = sorted(Path("w1/tc").glob(cls.glob_pattern))
+        # Path.glob is lazy, so wrap in list to get iteration ready paths...
+        cls.tcs = list(Path().glob(cls.glob_pattern))
 
     def read_lines(self, path: Path) -> Iterator[str]:
         """

w1/breaking_records.py

@@ -21,42 +21,21 @@ def breaking_records(scores: List[int]) -> List[int]:
         >>> breaking_records([3, 4, 21, 36, 10, 28, 35, 5, 24, 42])
         [4, 0]
     """
-    # keep track of the low and high scores.
-    hc = [] # note: final high count is this list length
-    lc = [] # note: final low count is the count of this list
-
-    # so that we can keep track of the things processes
-    processed = []
-
-    # iterate over the scores
-    for s in scores:
-        # max min are functions of what is processed
-        try:
-            _mx = max(processed)
-        except ValueError:
-            # zero is not class as a high score so if the score
-            # was zero, count it as processed and continue on.
-            processed.append(s)
-            continue
-
-        try:
-            _mn = min(processed)
-        except ValueError:
-            _mn = 0
-
-        # count the highs and lows
-        if s > _mx:
-            hc.append(s)
-
-        if s < _mn:
-            lc.append(s)
-        
-        # value was processesed, so append it
-        processed.append(s)
-
-
-    # done, return the count
-    return [
-        len(hc),
-        len(lc)
-    ]
+    # keep track of the counts of breaks for min score and max score
+    min_b = max_b =0
+
+    # start off with 0 for max and min counts
+    mx = mn = scores[0]
+
+    for score in scores[1:]:
+
+        if score > mx:
+            mx = score
+            max_b += 1
+
+        elif score < mn :
+            mn = score
+            min_b += 1
+
+    # all done
+    return [max_b, min_b]

w1/breaking_records_test.py

@@ -2,6 +2,7 @@
 Tests for Breaking Records
 """
 from pathlib import Path
+from typing import ClassVar
 from test import testutils
 from w1.breaking_records import breaking_records
 
@@ -11,12 +12,12 @@ class BreakRecordsTest(testutils.TestCase):
     """
     Breaking records test cases
     """
-    glob_pattern = "w1/tc/4_*.txt"
+    glob_pattern: ClassVar[str] = "w1/tc/4_*.txt"
 
     def test_breaking_records(self):
         """(W1/4): Breaking Records"""
-        for tc in self.tcs:
 
+        for tc in self.tcs:
             # use a subtest scope
             with self.subTest(tc=tc):
                 # read in the lines
@@ -29,4 +30,5 @@ def test_breaking_records(self):
                 expected = [int(value) for value in lines[3].split()]
 
                 # we get what we expected
-                self.assertEqual(breaking_records(args), expected)
+                results = breaking_records(args)
+                self.assertEqual(results, expected)