Add test cases for binding

[jake-jake-jake]

I can add some more test cases for these if it makes sense to do so; these are the more obvious ones that occurred to me.

[jeaye]

Great tests. What do you think about adding some tests for binding conveyance across threads? When a thread is created, it should copy the current binding state and changes made to bindings should only be visible on the current thread.

[jake-jake-jake]

Great tests. What do you think about adding some tests for binding conveyance across threads? When a thread is created, it should copy the current binding state and changes made to bindings should only be visible on the current thread.

Yeap, happy to add those. I wasn't sure we wanted to mess with threads in these, but if we are, we should test those cases.

I put up some that test threaded bindings via futures as well as how delay handles them. The tests are failing in CI, and I'll dig into a possible solution later this weekend/early next week, unless we already have a workaround for threaded execution. A quick search turns this up, which I think might be the cause (since the tests pass in my CIDER session).

[jake-jake-jake]

I pushed up a hack to make this pass. It's not the most satisfying solution, but it does make things work for now. If there is a better way to direct lein to run specific tests alone, I am happy to change this to do that but I didn't see anything obvious in the docs or through digging around.

[jeaye]

Nice! We just merged this PR: #37

Would you mind wrapping your new binding file in the same macro before I merge?

[jake-jake-jake]

Done!

[jeaye]

Hm, this will cause issues with any other tests using threads. Does it make sense to add a shutdown hook instead?

; In portability.cljc
(defn shutdown-agents-on-close []
  #?(:clj (.addShutdownHook (Runtime/getRuntime) (Thread. ^Runnable shutdown-agents))))

Taken from here: https://medium.com/helpshift-engineering/achieving-graceful-restarts-of-clojure-services-b3a3b9c1d60d

[jake-jake-jake]

It looks like that was what was happening with the threads in these tests! There was a different shutdown agents call in add_watch.cljc. I removed it and these tests pass without any issues now.

[jeaye]

Great work!