Skip to content

Conversation

@pawelqs
Copy link

@pawelqs pawelqs commented Nov 19, 2025

  • fix: correct position calculation in ggEvidenceplot function
  • tests: adds test of ggEvidenceplot function

@pawelqs
Copy link
Author

pawelqs commented Nov 19, 2025

Fixes #3

@january3 january3 merged commit 5e1c056 into january3:master Nov 28, 2025
@january3
Copy link
Owner

Zrobione, wielkie dzięki!

Frankly I abandoned the ggEvidenceplot function because I was not able to implement gene labels due to the conceptual limits of the ggplot engine. You simply cannot know how label font sizes translate to user coordinates, so I would have to meddle with low level grid functions.

@pawelqs
Copy link
Author

pawelqs commented Dec 2, 2025

No problem ;)
Regarding the gene labels - I used to do similar things with ggrepel. Have you tried to solved that way?

@january3
Copy link
Owner

january3 commented Dec 3, 2025

Nah, ggrepel doesn't work here, not if you have more than a couple of genes. Maybe I should put it back in, it is better than nothing (then again, the user can simply add the ggrepel() call to the object returned by ggEvidencePlot). New tmod release coming soon, but I need to fix one more bug first.

@pawelqs
Copy link
Author

pawelqs commented Dec 7, 2025

It does not scale well to hundreds of genes, but works pretty good for few dosens if the labels are aligned like this:
https://ggrepel.slowkow.com/articles/examples#align-labels-on-the-top-or-bottom-edge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants