Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage not part of templates' .gitignore #922

Open
mimshwright opened this issue Nov 4, 2020 · 1 comment · May be fixed by #925
Open

coverage not part of templates' .gitignore #922

mimshwright opened this issue Nov 4, 2020 · 1 comment · May be fixed by #925
Labels
good first issue Good for newcomers kind: feature New feature or request PR welcome scope: templates Related to an init template, not necessarily to core (but could influence core) solution: workaround available There is a workaround available for this issue

Comments

@mimshwright
Copy link

Current Behavior

  1. run yarn test --coverage to generate a coverage report.
  2. run git status
  3. /coverage/ is part of the list of changed files.

Expected behavior

It should be ignored by git.

Suggested solution(s)

Append coverage to .gitignore
@mimshwright
Copy link
Author

mimshwright commented Nov 4, 2020 •
edited by agilgur5
Loading

Mentioned in #10 (comment)

@mimshwright mimshwright mentioned this issue Nov 4, 2020
Closed
mimshwright added a commit to mimshwright/tsdx that referenced this issue Nov 4, 2020
@mimshwright
Update gitignore template to add coverage
2588e55 
fixes jaredpalmer#922
@mimshwright mimshwright mentioned this issue Nov 4, 2020
Closed
@agilgur5 agilgur5 changed the title coverage not part of .gitignore coverage not part of templates' .gitignore Nov 4, 2020
@agilgur5 agilgur5 added good first issue Good for newcomers PR welcome scope: templates Related to an init template, not necessarily to core (but could influence core) kind: feature New feature or request solution: workaround available There is a workaround available for this issue labels Nov 4, 2020
@mimshwright mimshwright linked a pull request Nov 4, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind: feature New feature or request PR welcome scope: templates Related to an init template, not necessarily to core (but could influence core) solution: workaround available There is a workaround available for this issue
Projects
None yet
Milestone
No milestone
2 participants
@mimshwright @agilgur5