-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Loading Component to Recent Searches Island #31
Comments
Hi, can I be assigned to this? |
Sure @amiabl-programr, Kindly share how you intend to implement this, I do have ideas but I'd like it to maybe augment your approach 😉 |
I'd create a loading component in the same folder, and pass down the recent searches data to the loading component as a prop from "recent-searches.jsx" to get the exact size of each item in the recent searches section. The loading component will be visible while the data is being fetched, and a delay of 2s will be added to prevent the loader from flashing in case the data was returned very fast. |
Haha, yea.... this was how you approached it 😃 But, this is still working with what's already loaded on the client-side. Not what I would've done nor what I was expecting yea 😉 The I was looking to have this clear discussion before you started a PR 😉 |
Well, you just replied... 🥲 |
The Recent Searches island component currently lacks a loading state, causing the UI to flicker when content is loaded. This issue aims to add a loading component to improve user experience.
screencast-localhost_4321-2024.04.05-12_20_32.webm
Tasks
Related Files
recent-searches.jsx
component in thesrc/components/islands
directoryAcceptance Criteria
Additional Notes
The text was updated successfully, but these errors were encountered: