From 4c3bbb5b020392446f6667ebb035080aa79f24f6 Mon Sep 17 00:00:00 2001 From: Shun Wang Date: Sun, 23 Nov 2025 00:28:36 +0800 Subject: [PATCH 1/3] remove unnecessary empty row from result table --- Desktop/html/css/jasp.css | 15 --------------- Desktop/html/js/table.js | 2 -- 2 files changed, 17 deletions(-) diff --git a/Desktop/html/css/jasp.css b/Desktop/html/css/jasp.css index 0f4c942892..ad493fc19b 100644 --- a/Desktop/html/css/jasp.css +++ b/Desktop/html/css/jasp.css @@ -141,14 +141,12 @@ tbody th { tbody th, tbody td { - border-bottom : none ; border-top : none; white-space: nowrap; } thead tr th { - border-bottom: thin solid ; } @@ -182,12 +180,10 @@ div.over-title-space:empty { tbody tr:last-child th, tbody tr:last-child td { - border-bottom: thin solid ; } tbody tr td.new-sub-group-row { - padding-top: .4em ; } @@ -200,7 +196,6 @@ tbody tr:first-child td { tbody tr:nth-last-child(2) td.last-group-row, tbody tr:nth-last-child(2) td, tbody tr:nth-last-child(2) th { - margin-bottom: .8em ; } @@ -245,33 +240,28 @@ svg > text .jasp_top_level { - margin-left: 1.7em ; margin-right: 1.7em ; } :not(.error-state) > .jasp-analysis { - margin: 0 .7em .7em .7em ; padding: 0 1em 1em 1em ; position: relative; } #instructions { - margin: .7em ; padding: 1em ; /*display: inline-block ;*/ } div.toolbar { - display: block ; position: relative; } div.image-status { - position: absolute ; top : 0 ; left: 0 ; @@ -284,7 +274,6 @@ div.image-status { } div.status { - width: 16px ; height: 16px ; background-size : 100% ; @@ -321,7 +310,6 @@ div.jasp-image-image.no-data { } .error-message-positioner { - height: 0px ; overflow: visible ; position: relative; @@ -331,19 +319,16 @@ div.jasp-image-image.no-data { } .jasp-image-image .error-message-positioner { - position: absolute ; top: 25% ; } .error-message-symbol { - float: left; margin-right: .3em; } .error-message-box { - z-index: 100 ; padding: 1em ; border-radius: .4em ; diff --git a/Desktop/html/js/table.js b/Desktop/html/js/table.js index 0bfbd1309c..f229814902 100644 --- a/Desktop/html/js/table.js +++ b/Desktop/html/js/table.js @@ -733,8 +733,6 @@ JASPWidgets.tablePrimitive = JASPWidgets.View.extend({ chunks.push('') } - chunks.push('') - chunks.push('') if (optFootnotes) { From 1182fc96ff138c69a42496d3a3c9cdf0fab0129a Mon Sep 17 00:00:00 2001 From: Shun Wang Date: Sun, 23 Nov 2025 15:45:00 +0800 Subject: [PATCH 2/3] keep the gap in last row bottom border for visual balance. --- Desktop/html/css/jasp.css | 1 + 1 file changed, 1 insertion(+) diff --git a/Desktop/html/css/jasp.css b/Desktop/html/css/jasp.css index ad493fc19b..a3b0355f47 100644 --- a/Desktop/html/css/jasp.css +++ b/Desktop/html/css/jasp.css @@ -181,6 +181,7 @@ div.over-title-space:empty { tbody tr:last-child th, tbody tr:last-child td { border-bottom: thin solid ; + box-shadow: inset 0 -.15em 0 #ffffff ; /* minor gap between the bottom border and the background shadow to keep visual balance. */ } tbody tr td.new-sub-group-row { From b3ccf019ba06e59dcb990be92e99617d222bdd61 Mon Sep 17 00:00:00 2001 From: Shun Wang Date: Wed, 26 Nov 2025 19:56:43 +0800 Subject: [PATCH 3/3] dont draw bottom border for squash-left cell --- Desktop/html/css/jasp.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Desktop/html/css/jasp.css b/Desktop/html/css/jasp.css index a3b0355f47..9313e9cc17 100644 --- a/Desktop/html/css/jasp.css +++ b/Desktop/html/css/jasp.css @@ -179,7 +179,7 @@ div.over-title-space:empty { tbody tr:last-child th, -tbody tr:last-child td { +tbody tr:last-child td:not(.squash-left) { border-bottom: thin solid ; box-shadow: inset 0 -.15em 0 #ffffff ; /* minor gap between the bottom border and the background shadow to keep visual balance. */ }