You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
4.**Address review comments until all reviewers give LGTM ('looks good to me').**
78
78
* Resolve any merge conflicts that arise.
79
-
* Run `bash scripts/start.sh` and play with the dev server in order to make sure that everything still works, and also to install any new dependencies that have been added since you last synced the repo.
79
+
* Run `python -m scripts.start` and play with the dev server in order to make sure that everything still works, and also to install any new dependencies that have been added since you last synced the repo.
80
80
* WARNING: Do not make changes using the online GitHub editor -- this bypasses lint/presubmit checks, and will cause the code on GitHub to diverge from the code on your machine. Always make commits locally, and then push to GitHub.
81
81
82
82
5. Tidy up! After the PR status has changed to "Merged", delete the feature branch from both your local clone and the GitHub repository
@@ -107,16 +107,38 @@ Starter project
107
107
*[Project 8: Improve unit tests](#project-8-improve-unit-tests)
108
108
109
109
Easy
110
-
*[Project 2: Create toasts for success messages](#project-2-create-toasts-for-success-messages)
*[Project 9: Writing Selenium tests for interactions](#project-9-writing-selenium-tests-for-interactions)
113
-
*[Project 10: Expose "upload exploration" functionality in admin page](#project-10-expose-upload-exploration-functionality-in-admin-page)
114
-
*[Project 13: Find ways to make the audio translation tab interface clearer](#project-13-find-ways-to-make-the-audio-translation-tab-interface-clearer)
115
-
*[Project 14: Feedback threads in feedback tab do not reorder by recent updates in real time](#project-14-feedback-threads-in-feedback-tab-do-not-reorder-by-recent-updates-in-real-time)
*[Project 19: Accessibility Improvements - Fixing Contrast in Image Region Selectors](#project-19-accessibility-improvements---fixing-contrast-in-image-region-selectors)
110
+
-[Getting Ready for Open Source Day](#getting-ready-for-open-source-day)
111
+
-[Table Of Contents](#table-of-contents)
112
+
-[How To Get Started](#how-to-get-started)
113
+
-[Setting Up Before Open Source Day](#setting-up-before-open-source-day)
114
+
-[Sign the CLA](#sign-the-cla)
115
+
-[Create a GitHub account](#create-a-github-account)
116
+
-[Install Oppia on your machine](#install-oppia-on-your-machine)
117
+
-[Join the Gitter channel](#join-the-gitter-channel)
118
+
-[Some useful links](#some-useful-links)
119
+
-[Making A Code Change](#making-a-code-change)
120
+
-[What to do when you are stuck](#what-to-do-when-you-are-stuck)
121
+
-[List of Projects](#list-of-projects)
122
+
-[Project List](#project-list)
123
+
-[Project 1: Implement a reusable sort/filter list view for skills](#project-1-implement-a-reusable-sortfilter-list-view-for-skills)
124
+
-[Project 2: Create toasts for success messages](#project-2-create-toasts-for-success-messages)
125
+
-[Project 3: Use case-insensitive names rather than IDs in the URL for a topic](#project-3-use-case-insensitive-names-rather-than-ids-in-the-url-for-a-topic)
126
+
-[Project 4: Allow users to suggest new questions for a skill](#project-4-allow-users-to-suggest-new-questions-for-a-skill)
127
+
-[Project 5: Allow users to suggest edits to concept cards](#project-5-allow-users-to-suggest-edits-to-concept-cards)
128
+
-[Project 6: Allow translators to see the changes made in content by editor](#project-6-allow-translators-to-see-the-changes-made-in-content-by-editor)
-[Project 8: Improve unit tests](#project-8-improve-unit-tests)
131
+
-[Project 9: Writing Selenium tests for interactions](#project-9-writing-selenium-tests-for-interactions)
132
+
-[Project 10: Expose "upload exploration" functionality in admin page](#project-10-expose-%22upload-exploration%22-functionality-in-admin-page)
133
+
-[Project 11: Randomize the pretest questions.](#project-11-randomize-the-pretest-questions)
134
+
-[Project 12: Multiple choice answers could be shuffled](#project-12-multiple-choice-answers-could-be-shuffled)
135
+
-[Project 13: Find ways to make the audio translation tab interface clearer](#project-13-find-ways-to-make-the-audio-translation-tab-interface-clearer)
136
+
-[Project 14: Feedback threads in feedback tab do not reorder by recent updates in real time](#project-14-feedback-threads-in-feedback-tab-do-not-reorder-by-recent-updates-in-real-time)
page_test is the name of the file containing that test eg. splash_test. Refer to `core/tests/performance_tests` directory for the files containing these tests.
14
14
15
15
### The Framework.
16
16
17
-
The framework has two major components to it:
17
+
The framework has two major components to it:
18
18
19
-
1. Performance Data Fetcher:
20
-
We use selenium and browsermob-proxy to fetch performance data for the different Oppia pages.
21
-
Selenium helps in programmatically interacting with a browser and browsermob-proxy is used to capture HTTP Archive (referred to as HAR) data by recording the communication between the client and server.
19
+
1. Performance Data Fetcher:
20
+
We use selenium and browsermob-proxy to fetch performance data for the different Oppia pages.
21
+
Selenium helps in programmatically interacting with a browser and browsermob-proxy is used to capture HTTP Archive (referred to as HAR) data by recording the communication between the client and server.
22
22
The **HTTP Archive** format is a JSON-formatted archive file format used for logging a web browser's interaction with a site. It contains detailed performance data, including information about page loading and displaying and per-resource statistics. Each entry contains the URL requested and request and response headers. For additional details, please see: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/HAR/Overview.html
23
23
24
-
2. Performance Metrics Provider:
25
-
Refer to: `PageSessionMetrics` and `MultiplePageSessionMetrics` objects in `perf_domain.py`.
24
+
2. Performance Metrics Provider:
25
+
Refer to: `PageSessionMetrics` and `MultiplePageSessionMetrics` objects in `perf_domain.py`.
26
26
27
27
### Metrics that we consider.
28
28
@@ -62,4 +62,4 @@ To write tests for a new Oppia page:
62
62
### Issues
63
63
64
64
*`WebDriverException: Message: chrome not reachable`:
65
-
Try setting bypass proxy for local addresses if you are behind a proxy server.
65
+
Try setting bypass proxy for local addresses if you are behind a proxy server.
0 commit comments