Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document serialization API for panels. #1809

Conversation

tim-schilling
Copy link
Member

Fixes #1806

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@matthiask
Copy link
Member

The lint step fails with ../debug_toolbar/panels/__init__.py:docstring of debug_toolbar.panels.Panel.deserialize_stats:1: : Spell check: Deserialize: Deserialize stats coming from the store..

I don't know what's going on with MariaDB/MySQL.

@tim-schilling
Copy link
Member Author

I don't think we're going to keep these API functions in. I'm discovering that I'd prefer to make the panel simply prepare the data in a serializable format rather than patch it in afterwards.

@tim-schilling
Copy link
Member Author

Regarding mysql, I probably need to rebase on main.

@matthiask
Copy link
Member

I'm discovering that I'd prefer to make the panel simply prepare the data in a serializable format rather than patch it in afterwards.

Good point, makes sense to me.

@tim-schilling
Copy link
Member Author

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants