Skip to content

APNS category broken in 3.2.0 #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronn opened this issue Jan 17, 2025 · 7 comments · Fixed by #760
Closed

APNS category broken in 3.2.0 #757

aaronn opened this issue Jan 17, 2025 · 7 comments · Fixed by #760

Comments

@aaronn
Copy link

aaronn commented Jan 17, 2025

As part of django-push-notifications 3.2.0 with apns-async, send_message no longer seems to expect category and will throw the following error:

apns_send_bulk_message() got an unexpected keyword argument 'category'

Anyone else running into this or have any ideas for a workaround?

@aaronn
Copy link
Author

aaronn commented Jan 18, 2025

Potential fix here: #758

@50-Course
Copy link
Member

Hi @aaronn, would take a look at the potential fix, there had been couple of reports about broken changes with recent releases, not fully backwards compatible. We're currently looking into that -- PRs are more than welcome!

@HashimJVZ
Copy link
Contributor

This is similar to #755 , both comes under aps_kwargs.

@HashimJVZ
Copy link
Contributor

@aaronn Can you check my fix #760 works?

@HashimJVZ
Copy link
Contributor

Can we close this issue and its already merged? Or do we close after release?

@HashimJVZ HashimJVZ linked a pull request Feb 24, 2025 that will close this issue
@HashimJVZ
Copy link
Contributor

@50-Course , can we have a patch release to make this issues resolved?

@50-Course
Copy link
Member

Hello @HashimJVZ new released just got published by @jamaalscarlett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@aaronn @jamaalscarlett @HashimJVZ @50-Course and others