Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New line ignored when using delimiter #26

Open
TackTick opened this issue Nov 27, 2021 · 3 comments
Open

[BUG] New line ignored when using delimiter #26

TackTick opened this issue Nov 27, 2021 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@TackTick
Copy link

TackTick commented Nov 27, 2021

Description
When reading from a text file created by NotePad (Windows 10), using a custom delimiter, sometimes a line feed/return gets ignored.

To Reproduce
1 Open the source containing the text slide show
2 Choose 'Read from single file' and 'Use custom delimiter'
3 Use (in this case) '$' as a custom delimiter (the problem occurs with other delimiters as well)
4 Use the text file attached to this bug report, containing 200 sample lines
5 The concatenated lines are visible in the preview (see screen shot) as well as in the source itself
6 The occurrences of the concatenated lines are consistent but a pattern is not apparent as of yet

Expected behavior
Expected behavior: no concatenation.

Screenshots
afbeelding

Desktop

  • OS Version: Windows 10 21H2
  • OBS version: 27.1.3
  • GDI+ Text Slide Show (version 1.5.2 via Windows installer)

Additional context
n/a

Sample file
OTSS delim CR ignored.txt

PS
I would like to donate for your work. As I am new to Github, I do not know the best way to do that yet :-)

@TackTick TackTick added the bug Something isn't working label Nov 27, 2021
jbwong05 added a commit that referenced this issue Nov 27, 2021
Fixed issue where the new line character ending up on the CHUNK boundary
would end up getting consumed even though there is no proceeding or
trailing delimiter
@jbwong05
Copy link
Owner

Fix for the incorrect new line handling has been pushed and just needs to be tested. Also, thank you @TackTick for your extensive testing and efforts in trying to make bugs reproducible. It makes the debugging and patching process that much easier. With regards to supporting my work, I do need to setup a patreon page. I just haven't gotten around to it yet. That being said, there is never any pressure to contribute financially and I do provide this plugin as a piece of open source software free of charge. If you still wish to financially contribute though, it would be much appreciated and I will hopefully have a contribution link setup sometime soon.

@jbwong05
Copy link
Owner

@TackTick For now I have setup a Paypal donation link. It can be found by clicking on the Sponsor button now on the github page or as a badge at the top of the README. Once again, there is absolutely no pressure to financially contribute or donate. I am happy to provide this plugin as FOSS

@TackTick
Copy link
Author

Nice! FOSS can always use more sponsors.

@jbwong05 jbwong05 added this to the v1.5.3 milestone Dec 2, 2021
jbwong05 added a commit that referenced this issue Dec 21, 2022
Fixed issue where the new line character ending up on the CHUNK boundary
would end up getting consumed even though there is no proceeding or
trailing delimiter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants