Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request: frameCount #100

Open
tonytoms opened this issue Oct 7, 2020 · 0 comments
Open

Change Request: frameCount #100

tonytoms opened this issue Oct 7, 2020 · 0 comments

Comments

@tonytoms
Copy link

tonytoms commented Oct 7, 2020

Hi.
Thanks a lot for the awesome lib.
I was using it in my react app with the SpriteAnimator component.
I finding a naming convention bit weird. The 'framecount' is actually not the total frames that will be played from the 'startFrame'. It's actually the ending frame.
That is ,
startFrame=2 ,framecount=5 => will make the lib play frames 2,3 and 4.
It's a bit confusing.
So, it's a humble suggestion to rename framecount to endframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant