Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values for impatient-showdown-flavor #6

Open
buhtz opened this issue Jan 5, 2023 · 4 comments
Open

Values for impatient-showdown-flavor #6

buhtz opened this issue Jan 5, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@buhtz
Copy link

buhtz commented Jan 5, 2023

From the docu it is unclear which values are possible for impatient-showdown-flavor.

@jcs090218
Copy link
Member

Yeah... sorry about the documentation. The value can be found in the code:

(defcustom impatient-showdown-flavor 'original
"Display markdown depends on your flavor."
:type '(choice (const :tag "original" original)
(const :tag "vanilla" vanilla)
(const :tag "github" github))
:group 'impatient-showdown)

These are flavors from showdown, see https://github.com/showdownjs/showdown#flavors.

@buhtz
Copy link
Author

buhtz commented Jan 5, 2023

I assume I do something wrong with the syntax.

(use-package impatient-showdown
  :hook
  (markdown-mode . impatient-showdown-mode)
  :init
  (setq impatient-showdown-flavor "github")
  (setq impatient-showdown-background-color "#9d9d9d")
  (setq impatient-showdown-markdown-background-color "#f7f1ec")
  )

The result looks like an error

grafik

@jcs090218
Copy link
Member

It should be a symbol, not a string:

(setq impatient-showdown-flavor 'github)

@jcs090218 jcs090218 added the documentation Improvements or additions to documentation label Jan 5, 2023
@buhtz
Copy link
Author

buhtz commented Jan 5, 2023

Ah. OK, now it "works" without errors.
But the visual result looks identical between each of the three options (default, vanilla and github).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants